New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save 50MB (35pu one thread) by not copying stuff around in TkConvValidator #17484
Conversation
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_9_0_X. It involves the following packages: Validation/RecoEgamma @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@@ -969,7 +970,7 @@ void TkConvValidator::analyze( const edm::Event& e, const edm::EventSetup& esup | |||
theConvTP_.clear(); | |||
// std::cout << " TkConvValidator TrackingParticles TrackingParticleCollection size "<< trackingParticles.size() << "\n"; | |||
//duplicated TP collections for two associations | |||
for(TrackingParticleRef tp: tpForEfficiency) { | |||
for(const TrackingParticleRef tp: tpForEfficiency) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The loop variable could also be a & which would be a bit faster.
No description provided.