update DependencyGraph service

[fwyzard]

• show plugin class in tooltip (SVG only)
• highlight a list of modules

[fwyzard]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17746/console Started: 2017/02/11 15:32

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_9_0_X.

It involves the following packages:

FWCore/Services

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[fwyzard]

I would like to add a helper function for this and similar services, to extract the list of modules from a sequence:

def modules_in_sequences(* sequences):
  from FWCore.ParameterSet.SequenceTypes import ModuleNodeVisitor
  modules = []
  for sequence in sequences:
    sequence.visit(ModuleNodeVisitor(modules))
  return [ module.label() for module in modules ]

Any suggestions where it should go ?

[cmsbuild]

+1
Tested at: 58921b3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17492/17746/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17492/17746/summary.html

[Dr15Jones]

@fwyzard I guess the helper function could go into FWCore.ParameterSet.Utilities?

[cmsbuild]

Pull request #17492 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

[fwyzard]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17771/console Started: 2017/02/14 08:53

[fwyzard]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17772/console Started: 2017/02/14 09:40

[cmsbuild]

Pull request #17492 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

[fwyzard]

@Dr15Jones do you think the python is OK ?
it would be nice to have similar functions for Tasks, once they are in

[cmsbuild]

+1
Tested at: 9652daa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17492/17772/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17492/17772/summary.html

[wddgit]

After the Task PR is integrated, the function (modulesInSequences) as written will already would work just fine if you put tasks in the list passed in as an argument. In addition, if there are tasks associated with a sequence the visitor will already visit the modules on those associated tasks if the sequence is passed in as an argument. You might consider renaming the function, but other than that it should just work.

[wddgit]

One other comment. After the Task PR is merged, the output list of modulesInSequences could contain ESProducers, ESSources and Services even when it is run on a Sequence because of the potential of tasks associated to the sequence. I have not looked at how that output list is used or whether that might cause problems.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[fwyzard]

Hi David, thanks for the comment.
The current use case should still be fine, but I'll update the function to return only ED modules.

[davidlange6]

+1