organize HLT trigger rate plots in directories #17519
Conversation
|
A new Pull Request was created by @mtosi (mia tosi) for CMSSW_9_0_X. It involves the following packages: DQM/HLTEvF @perrotta, @cmsbuild, @silviodonato, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
it would be useful to have this PR merged in 900pre5, |
| int nbinsX = 0; | ||
| int ibinY = 1; | ||
| for ( auto const & me : mes ) { | ||
| std::cout << "me: " << me << std::endl; |
|
Pull request #17519 was updated. @perrotta, @cmsbuild, @silviodonato, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please check and sign again. |
|
Pull request #17519 was updated. @perrotta, @cmsbuild, @silviodonato, @dmitrijus, @Martin-Grunewald, @fwyzard, @vanbesien, @davidlange6 can you please check and sign again. |
|
+1 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
| // ensure each dataset is incremented only once per event | ||
| break; | ||
| } | ||
| for (unsigned int i = 0; i < m_datasets[d].size(); ++i) { |
There was a problem hiding this comment.
this looks like a bug - i is used in two loops at once. Is it really correct?
@mtosi
There was a problem hiding this comment.
apparently the comment I wrote 10 days ago was not committed .. it seemed to me so, but it was not !
the comment was
loop opened in line 361 gets closed in 366,
not that the for instance does not have the for (unsigned int i: m_datasets[d])
in addition, the compiler does not complain, above all in this case where the variable i gets different types
There was a problem hiding this comment.
ah - ok, I missed the lack of a {} for the loop starting on line 361 (the } on line 366 closes the if statement started on 362)
There was a problem hiding this comment.
right
is it ok ?
thanks
|
ciao |
|
@mtosi |
|
yes, last week, but I replied to them, didn't I ? |
|
@mtosi |
|
-1 |
|
+1 |
|
thanks !
and sorry again for the delay, but from my window it seemed my comment was
posted ...
mia
…On Mon, Feb 27, 2017 at 1:21 PM, cmsbuild ***@***.***> wrote:
Merged #17519 <#17519>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17519 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AEt58-2MuFtgB3NodflxIrI1QrSwnyycks5rgs3xgaJpZM4MBkYQ>
.
|
The compiler does not necessarily complain if you reuse the same variable in a nested loop. for (unsigned int i = 0; i < 3; ++i)
for (double i = 0.; i < 3.; ++i)
for (auto const & i: std::vector<std::string>{ "Hello", " ", "world", "\n" })
std::cout << i;that will print 9 times |
as requested in JIRA #1158
this update is meant to re-organize HLT trigger paths in sub-directories
in order to speed up the displaying on the GUI
plots are created in directories depending on the PD the trigger belongs to
because the same trigger might be used in different PDs,
extra plots are created w.r.t. previous implementation
2 set of plots are dropped, instead,
they correspond to the paths HLTriggerFirstPath and HLTriggerFirstPath,
which are not needed to be monitored
the new TriggerMonitorRateClient is currently not used