bsunanda:Run2-hcx106 Correct list of valid DetId's and add possibility of getting position of merged DetId #17525

bsunanda · 2017-02-15T14:51:09Z

Essential for Plan1 operation

…of merged DetId

bsunanda · 2017-02-15T14:51:24Z

cmsbuild · 2017-02-15T14:51:28Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17800/console Started: 2017/02/15 16:28

cmsbuild · 2017-02-15T14:51:29Z

A new Pull Request was created by @bsunanda for CMSSW_9_0_X.

It involves the following packages:

Geometry/CaloTopology
Geometry/HcalCommonData
Geometry/HcalEventSetup
Geometry/HcalTowerAlgo

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

cmsbuild · 2017-02-15T15:49:02Z

-1

Tested at: a540a1a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17525/17800/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

In file included from /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/boost/1.57.0-oenich2/include/boost/lexical_cast/detail/converter_lexical_streams.hpp:64:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/boost/1.57.0-oenich2/include/boost/lexical_cast/detail/inf_nan.hpp:34:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/boost/1.57.0-oenich2/include/boost/math/special_functions/sign.hpp:16:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/boost/1.57.0-oenich2/include/boost/math/tools/config.hpp:335:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/boost/1.57.0-oenich2/include/boost/detail/fenv.hpp:97:
/cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/fenv.h:58:11: error: no member named 'fenv_t' in the global namespace
  using ::fenv_t;
        ~~^
/cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/fenv.h:59:11: error: no member named 'fexcept_t' in the global namespace
  using ::fexcept_t;
        ~~^

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-15-1100/src/Geometry/HcalEventSetup/src/CaloTowerHardcodeGeometryEP.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-15-1100/src/Geometry/HcalEventSetup/src/HcalAlignmentEP.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-15-1100/src/Geometry/HcalEventSetup/src/SealModule.cc 
>> Compile sequence completed for CMSSW CMSSW_9_0_X_2017-02-15-1100
+ echo ALL_OK
ALL_OK

cmsbuild · 2017-02-15T15:49:05Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

kpedro88 · 2017-02-15T17:06:42Z

@bsunanda the regular build error looks spurious, but the clang error seems real:

tmp/slc6_amd64_gcc530/MakeData/DirCache.mk:3: No such file exists: src/Geometry/HcalTowerAlgo/test/HcalDetIdTester.cc. Please fix src/Geometry/HcalTowerAlgo/test/BuildFile.
>> Local Products Rules ..... started
gmake: *** [src/Geometry/HcalTowerAlgo/test contains only BuildFile.xml without any sources. Better to remove BuildFile.xml too or do not tag this directory] Error 1

Can you fix it?

bsunanda · 2017-02-15T17:54:33Z

@smuzaffar This error is not due to this code. There is something else wrong in the environment for recent IB.

bsunanda · 2017-02-15T18:58:17Z

@cmsbuild Please test

cmsbuild · 2017-02-15T18:58:32Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17806/console Started: 2017/02/15 19:59

cmsbuild · 2017-02-15T19:19:08Z

-1

Tested at: a540a1a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17525/17806/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

In file included from /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/boost/1.57.0-oenich2/include/boost/lexical_cast/detail/converter_lexical_streams.hpp:64:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/boost/1.57.0-oenich2/include/boost/lexical_cast/detail/inf_nan.hpp:34:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/boost/1.57.0-oenich2/include/boost/math/special_functions/sign.hpp:16:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/boost/1.57.0-oenich2/include/boost/math/tools/config.hpp:335:
In file included from /cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/boost/1.57.0-oenich2/include/boost/detail/fenv.hpp:97:
/cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/fenv.h:58:11: error: no member named 'fenv_t' in the global namespace
  using ::fenv_t;
        ~~^
/cvmfs/cms-ib.cern.ch/nweek-02459/slc6_amd64_gcc530/external/gcc/5.3.0/include/c++/5.3.0/fenv.h:59:11: error: no member named 'fexcept_t' in the global namespace
  using ::fexcept_t;
        ~~^

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-15-1100/src/Geometry/HcalEventSetup/src/CaloTowerHardcodeGeometryEP.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-15-1100/src/Geometry/HcalEventSetup/src/HcalAlignmentEP.cc 
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-02-15-1100/src/Geometry/HcalEventSetup/src/SealModule.cc 
>> Compile sequence completed for CMSSW CMSSW_9_0_X_2017-02-15-1100
+ echo ALL_OK
ALL_OK

cmsbuild · 2017-02-15T19:19:11Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-02-16T08:46:44Z

+1
Tested at: 89a29dd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17525/17809/summary.html

cmsbuild · 2017-02-16T08:46:47Z

Comparison job queued.

cmsbuild · 2017-02-16T09:19:52Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17525/17809/summary.html

davidlange6 · 2017-02-16T13:43:50Z

Geometry/HcalCommonData/interface/HcalDDDSimConstants.h

@@ -40,7 +40,7 @@ class HcalDDDSimConstants {
 					  const int zside) const;
  int                       getDepthEta16M(const int det) const;
  int                       getDepthEta29(const int phi, int zside, int i) const;
-  int                       getDepthEta29M(const int i) const;
+  int                       getDepthEta29M(const int i, const bool flag) const;


Hi @bsunanda - here and in a few other places in this PR - could you either document what "flag" means or rather pick a more self documenting name?

@davidlange6 Done that - this is for special RBX's as in Plan One - so I name it planOne

bsunanda · 2017-02-16T14:34:34Z

@cmsbuild Please test

cmsbuild · 2017-02-16T14:34:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17822/console Started: 2017/02/16 18:18

cmsbuild · 2017-02-16T14:34:41Z

Pull request #17525 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again.

bsunanda · 2017-02-16T16:23:09Z

@civanch @davidlange6 Could you approve the request - I need to submit the next set of changes for Plan 1 once this is integrated

davidlange6 · 2017-02-16T18:48:02Z

Will assume tests are ok given previous tests

cmsbuild · 2017-02-16T19:30:52Z

+1
Tested at: 9743bf8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17525/17822/summary.html

cmsbuild · 2017-02-16T19:30:55Z

Comparison job queued.

cmsbuild · 2017-02-16T21:48:58Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17525/17822/summary.html

Corect list of valid DetId's and add possibility of getting position …

a540a1a

…of merged DetId

cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 15, 2017

cmsbuild added comparison-pending geometry-pending orp-pending pending-signatures tests-pending labels Feb 15, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 15, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Feb 15, 2017

cmsbuild added comparison-pending tests-pending tests-started and removed comparison-notrun tests-rejected tests-pending labels Feb 15, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 16, 2017

cmsbuild added tests-approved and removed tests-started labels Feb 16, 2017

cmsbuild added comparison-available and removed comparison-pending labels Feb 16, 2017

davidlange6 reviewed Feb 16, 2017

View reviewed changes

Change variable names to something more meaningful

9743bf8

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Feb 16, 2017

cmsbuild added tests-started and removed tests-pending labels Feb 16, 2017

davidlange6 merged commit a85956d into cms-sw:CMSSW_9_0_X Feb 16, 2017

cmsbuild added tests-approved and removed tests-started labels Feb 16, 2017

cmsbuild added comparison-available and removed comparison-pending labels Feb 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bsunanda:Run2-hcx106 Correct list of valid DetId's and add possibility of getting position of merged DetId #17525

bsunanda:Run2-hcx106 Correct list of valid DetId's and add possibility of getting position of merged DetId #17525

bsunanda commented Feb 15, 2017

bsunanda commented Feb 15, 2017

cmsbuild commented Feb 15, 2017 •

edited

cmsbuild commented Feb 15, 2017

cmsbuild commented Feb 15, 2017

cmsbuild commented Feb 15, 2017

kpedro88 commented Feb 15, 2017

bsunanda commented Feb 15, 2017

bsunanda commented Feb 15, 2017

cmsbuild commented Feb 15, 2017 •

edited

cmsbuild commented Feb 15, 2017

cmsbuild commented Feb 15, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

davidlange6 Feb 16, 2017

bsunanda Feb 16, 2017

bsunanda commented Feb 16, 2017

cmsbuild commented Feb 16, 2017 •

edited

cmsbuild commented Feb 16, 2017

bsunanda commented Feb 16, 2017

davidlange6 commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

bsunanda:Run2-hcx106 Correct list of valid DetId's and add possibility of getting position of merged DetId #17525

bsunanda:Run2-hcx106 Correct list of valid DetId's and add possibility of getting position of merged DetId #17525

Conversation

bsunanda commented Feb 15, 2017

bsunanda commented Feb 15, 2017

cmsbuild commented Feb 15, 2017 • edited

cmsbuild commented Feb 15, 2017

cmsbuild commented Feb 15, 2017

cmsbuild commented Feb 15, 2017

kpedro88 commented Feb 15, 2017

bsunanda commented Feb 15, 2017

bsunanda commented Feb 15, 2017

cmsbuild commented Feb 15, 2017 • edited

cmsbuild commented Feb 15, 2017

cmsbuild commented Feb 15, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

davidlange6 Feb 16, 2017

Choose a reason for hiding this comment

bsunanda Feb 16, 2017

Choose a reason for hiding this comment

bsunanda commented Feb 16, 2017

cmsbuild commented Feb 16, 2017 • edited

cmsbuild commented Feb 16, 2017

bsunanda commented Feb 16, 2017

davidlange6 commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 16, 2017

cmsbuild commented Feb 15, 2017 •

edited

cmsbuild commented Feb 15, 2017 •

edited

cmsbuild commented Feb 16, 2017 •

edited