Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBHE M3 = resynch offline with online setting #17563

Merged
merged 1 commit into from Feb 19, 2017

Conversation

mariadalfonso
Copy link
Contributor

This PR resynch the offline auxiliary information of the M3 with what is effectively runned in the HLT.
https://github.com/cms-sw/cmssw/blob/CMSSW_9_0_0_pre4/HLTrigger/Configuration/python/customizeHLTforHCALPhaseI.py#L91

Doesn't change the M3 algo neither the HLT content.
It only fix the content of the auxiliary information in the HBHE recHit, that is used as reference for any development and diagnose.

This is the effect
http://dalfonso.web.cern.ch/dalfonso/M2M3_PRresynch.png
and the difference is traceable to a difference in the timeslew parameters.
As far as I can see this mismatch is there since 2015

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mariadalfonso for CMSSW_9_0_X.

It involves the following packages:

RecoLocalCalo/HcalRecProducers

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 18, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17866/console Started: 2017/02/18 22:35

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 19, 2017

+1

for #17563 1f68e8f

  • implemented as described: timeSlewParsType for offline changes from 1 to 3 in agreement with what we have in the HLT settings
  • jenkins tests pass and comparisons with baseline show changes only in the offline M3-related plots; typically, there is a moderate increase in the energy

e.g. from 136.731 (singlePhoton PD in 2016B)
wf136 731_m3_hb1_ieta
wf136 731_m3_he1_ieta

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c79aca3 into cms-sw:CMSSW_9_0_X Feb 19, 2017
@mariadalfonso mariadalfonso mentioned this pull request Mar 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants