Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[90X] AlCaRecoTriggerBits updates #17568

Merged
merged 7 commits into from Feb 21, 2017
Merged

[90X] AlCaRecoTriggerBits updates #17568

merged 7 commits into from Feb 21, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 20, 2017

Greetings, in this PR:

  • allow the key replacement feature (leaving the list of attached trigger bit unchanged)
  • add a python wrapper script that allows the handling of multi-IOV changes in a single call (supports both condition DB and local sqlite file inputs)
  • refresh the configuration files in the CondTools/HLT folder to avoid warnings
  • add instructions to use the mult-IOV workflow

@cmsbuild cmsbuild added this to the Next CMSSW_9_0_X milestone Feb 20, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_9_0_X.

It involves the following packages:

CondTools/HLT

@perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @ggovi, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 20, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17880/console Started: 2017/02/20 11:53

@cmsbuild
Copy link
Contributor

+1
Tested at: e5c063f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17568/17880/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17568/17880/summary.html

@Martin-Grunewald
Copy link
Contributor

+1

@ggovi
Copy link
Contributor

ggovi commented Feb 21, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6
davidlange6 reviewed Feb 21, 2017
View reviewed changes
CondTools/HLT/src/AlCaRecoTriggerBitsRcdUpdate.cc Outdated
for(auto &iSet : alcarecoReplace ){
const std::string oldKey(iSet.getParameter<std::string>("oldKey"));
const std::string newKey(iSet.getParameter<std::string>("newKey"));
keyPairs.push_back(std::make_pair(oldKey,newKey));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich - please reserve the size of keyPairs. It is known in this case.

@cmsbuild
Copy link
Contributor

Pull request #17568 was updated. @perrotta, @cmsbuild, @silviodonato, @Martin-Grunewald, @fwyzard, @ggovi, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Feb 21, 2017

@davidlange6 done

@davidlange6 davidlange6 merged commit fc7c24c into cms-sw:CMSSW_9_0_X Feb 21, 2017
@franzoni franzoni mentioned this pull request Mar 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlange6 davidlange6 davidlange6 left review comments

Assignees
No one assigned
Labels
comparison-pending db-pending hlt-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
CMSSW_9_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmusich @cmsbuild @Martin-Grunewald @ggovi @davidlange6