Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoomed dxy(PV) and dz(PV) to MultiTrackValidator, and a B-hadron TP instance to standalone/trackingOnly modes #17591

Merged
merged 4 commits into from Feb 22, 2017

Conversation

makortel
Copy link
Contributor

This PR adds zoomed-in versions of dxy(PV) and dz(PV) to MultiTrackValidator, to better monitor the region of |dxy|<1cm that is important for b tagging. In addtion, an instance of MTV with B-hadron TrackingParticles is added to the standalone and trackingOnly sequences (possibly to be added to the standard sequence if proves to be useful in private tests).

Tested in 9_0_0_pre4, expecting appearance of *_dxypv_zoomed and *_dzpv_zoomed* histograms. No changes are expected in existing histograms.

@rovere @VinInn

In order to re-use the existing functionality, it was easiest to make
HistoryBase::evaluate() public (they kind of were already, via
TrackHistoryBase::evaluate()).
@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17905/console Started: 2017/02/21 18:04

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_9_0_X.

It involves the following packages:

SimTracker/TrackHistory
Validation/RecoTrack

@civanch, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@mtosi, @imarches, @felicepantaleo, @acaudron, @sdevissc, @GiacomoSguazzoni, @rovere, @VinInn, @JyothsnaKomaragiri, @mverzett, @threus, @wmtford, @ferencek, @pvmulder, @dgulhan this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Feb 22, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants