Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject 0 pt Puppi candidates in jet-track association #17626

Merged

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Feb 24, 2017

Charged PF candidates identified by the Puppi algorithm as pileup have their momenta scaled to 0. Consequently, eta and phi of such candidates are reset to 0 which can lead to spurious association of these candidates to jets whose axes point in the vicinity of (eta,phi)=(0,0). To reject such spurious associations, the candidate momentum is required to be greater than 0.

This change is completely transparent to all existing b-tagging algorithms and all monitored quantities. It manifests itself only in non-default setups where Puppi candidates are set as input for b tagging.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_9_0_X.

It involves the following packages:

RecoBTag/ImpactParameter

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@imarches, @acaudron, @JyothsnaKomaragiri, @mverzett, @ferencek, @pvmulder this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17958/console Started: 2017/02/24 23:49

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Mar 2, 2017

given backport to 80X, I think it's worth keeping this in 90X as well

@slava77
Copy link
Contributor

slava77 commented Mar 3, 2017

+1

for #17626 1866067

  • analysis-only change (in the current default workflows context); implemented as described
  • jenkins tests pass and comparisons confirm there are no differences

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 95d3b85 into cms-sw:CMSSW_9_0_X Mar 13, 2017
@ferencek ferencek deleted the JTAforPuppi-PR_from-CMSSW_9_0_0_pre4 branch March 15, 2017 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants