Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Wno-format-contains-nul if we have -Wno-format #17637

Merged
merged 2 commits into from Feb 27, 2017

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Feb 27, 2017

A recent change in GCC 7.0.1 now requires -Wformat if
-Wformat-contains-nul is used.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

A recent change in GCC 7.0.1 now requires -Wformat if
-Wformat-contains-nul is used.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_9_0_X.

It involves the following packages:

DataFormats/Math
MagneticField/Interpolation

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @namapane this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

Signed-off-by: David Abdurachmanov <davidlt@cern.ch>
@davidlt
Copy link
Contributor Author

davidlt commented Feb 27, 2017

please test

I have added another small commit for adding missing braces, noticed on slc7_aarch64_gcc700.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/17979/console Started: 2017/02/27 11:49

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 27, 2017

+1

for #17637 644dc8b

  • technical update; in line with the description
  • jenkins tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

davidlange6 commented Feb 27, 2017 via email

@cmsbuild cmsbuild merged commit 2acbbbc into cms-sw:CMSSW_9_0_X Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants