change MixItr to be const to avoid newing Crossingframe products #17640
Conversation
|
please test |
|
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_9_0_X. It involves the following packages: SimCalorimetry/CaloSimAlgos @civanch, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
The tests are being triggered in jenkins. |
|
+1 |
| for (MixCollection<PCaloHit>::MixItr hitItr = barrelHits->begin () ; | ||
| hitItr != barrelHits->end () ; | ||
| ++hitItr) { | ||
| for ( auto const & hitItr : barrelHits ) { |
There was a problem hiding this comment.
The variable name is a bit misleading since it is not an interator anymore.
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
fully-signed
simulation-approved
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar |
|
Pull request #17640 was updated. @civanch, @mdhildreth, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
replaces #17490 after changes suggested by @Dr15Jones