Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pcc 90 x #17647

Merged
merged 2 commits into from Mar 6, 2017
Merged

Pcc 90 x #17647

merged 2 commits into from Mar 6, 2017

Conversation

nfilipov
Copy link
Contributor

This PR affects only the Pixel Cluster Counting method. In this PR we:

  • add a switch to be respectful of the Phase2 tracker geometry (number of pixel barrel layers)
  • remove some Run 1 unused stuff (commented out already)
  • replace the TrackerGeometry::DetContainer loop, with an edmNew::DetSet loop that has the same effect.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @nfilipov (Nicolas Filipovic) for CMSSW_9_0_X.

It involves the following packages:

RecoLuminosity/LumiProducer

@cmsbuild, @cvuosalo, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 28, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18017/console Started: 2017/02/28 18:06
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18018/console Started: 2017/02/28 19:42

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor


int NumPixelBarrelLayers=3;
if(pixelPhase2Geometry){
NumPixelBarrelLayers=4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why is this only for phase2?
Doesn't phase-1 have the same feature?

@slava77
Copy link
Contributor

slava77 commented Mar 4, 2017

+1

for #17647 3cb09eb

  • test/analysis code, not used in standard/central workflows
  • jenkins tests pass: compiles

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit afaa624 into cms-sw:CMSSW_9_0_X Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants