Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to input collection tokens in PATJetProducer #17651

Merged

Conversation

ferencek
Copy link
Contributor

This PR updates the way jet flavor input tokens are assigned in the PATJetProducer in response to the problem reported in https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3726.html

No changes are expected in any of the produced output files. The expected change is that in PAT and MiniAOD workflows legacy flavor modules should no longer be executed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_9_0_X.

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @cvuosalo, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 28, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18016/console Started: 2017/02/28 17:58

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@perrotta
Copy link
Contributor

perrotta commented Mar 8, 2017

+1
Explicitly verified [1] (in 91X) that the fix actually prevents running unnecessarily the un-wanted pat modules.
Besides that, no differences are expected in the jenkins tests, and no differences were observed.

[1] $CMSSW_RELEASE_BASE/src/PhysicsTools/PatAlgos/test/patTuple_standard_cfg.py, as from the hn thread cited in the description of this PR

@davidlange6 davidlange6 merged commit e446eec into cms-sw:CMSSW_9_0_X Mar 15, 2017
@ferencek ferencek deleted the PATJetFix-PR_from-CMSSW_9_0_0_pre4 branch March 15, 2017 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants