Update the dataformat for the TP per crystal. It now follows what pre… #17669
Conversation
|
A new Pull Request was created by @nancymarinelli for CMSSW_9_0_X. It involves the following packages: DataFormats/EcalDigi @civanch, @mdhildreth, @cmsbuild, @rekovic, @kpedro88, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@nancymarinelli a few comments:
|
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Hello Pedro,
I will fix the root file thing. It was my mistake. As for rmeoving all
commented out software from C++ and/or python, tehre are certain thing
which I do not want lose memory of......
I will clean only whre I am sure of.
Nancy
…On 01/03/17 17:03, Kevin Pedro wrote:
@nancymarinelli <https://github.com/nancymarinelli> a few comments:
1. please remove all commented-out code (from both C++ and Python files)
2. ROOT files should not be tracked in Git unless /absolutely/
necessary - if the two ROOT files added in this PR are not
necessary, the commit needs to be remade without adding these
files so they never appear in the history (otherwise they inflate
the size of the repository forever)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17669 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEXjalW3m7fp0BwWTAmpzMYIRURi9hdQks5rhZbRgaJpZM4MPqdu>.
--
________________________________________
Nancy Marinelli
Research Associate Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
|
|
Pull request #17669 was updated. @civanch, @mdhildreth, @cmsbuild, @rekovic, @kpedro88, @mulhearn, @davidlange6 can you please check and sign again. |
|
@nancymarinelli as I stated in my previous comment, doing |
|
Comparison job queued. |
|
oh. sorry. I had not understood then. I remade the commit after removing
them. I though it would be enough. Sorry but I have no idea, then, on
how to go about it. None of what you suggest below gives me a useful hint.
Nancy
…On 01/03/17 17:24, Kevin Pedro wrote:
@nancymarinelli <https://github.com/nancymarinelli> as I stated in my
previous comment, doing |git rm *.root| in a subsequent commit is not
sufficient. The files will still take up space in the history as long
as they are in any commit in the PR. The initial commit needs to be
remade somehow (by hand, or using git tools like interactive rebase,
amend, or squashing options) so the files are never tracked.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#17669 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEXjaqlxgLGaf_sEzKJ094FHdVhXtRZ9ks5rhZvOgaJpZM4MPqdu>.
--
________________________________________
Nancy Marinelli
Research Associate Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
|
|
There are several ways to accomplish this using git. Here is one example based on "squashing" (i.e. combining) the two existing commits: Here you make a backup branch (in case of problems), use |
…sented to the L1-phase II workshop Dec 2016
nancymarinelli
force-pushed
the
TP_PhaseII_V1
branch
from
9686c98
to
64018c7
Compare
|
Pull request #17669 was updated. @civanch, @mdhildreth, @cmsbuild, @rekovic, @kpedro88, @mulhearn, @davidlange6 can you please check and sign again. |
|
Pull request #17669 was updated. @civanch, @mdhildreth, @cmsbuild, @rekovic, @kpedro88, @mulhearn, @davidlange6 can you please check and sign again. |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 3d0c710 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: >> Building edm plugin tmp/slc6_amd64_gcc530/src/Validation/EcalRecHits/src/ValidationEcalRecHits/libValidationEcalRecHits.so
Copying tmp/slc6_amd64_gcc530/src/SimCalorimetry/EcalTestBeamAlgos/src/SimCalorimetryEcalTestBeamAlgos/libSimCalorimetryEcalTestBeamAlgos.so to productstore area:
@@@@ Running edmWriteConfigs for ValidationPerformance
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-03-15-1100/src/DQM/L1TMonitor/interface/L1TOMDSHelper.h:6:0,
from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_0_X_2017-03-15-1100/src/DQM/L1TMonitor/src/L1TOMDSHelper.cc:1:
/cvmfs/cms-ib.cern.ch/nweek-02463/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-15-1100/src/CondTools/L1Trigger/interface/OMDSReader.h:57:23: error: 'AttributeList' is not a member of 'coral'
const std::vector< coral::AttributeList >& attLists )
^
/cvmfs/cms-ib.cern.ch/nweek-02463/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-15-1100/src/CondTools/L1Trigger/interface/OMDSReader.h:57:23: error: 'AttributeList' is not a member of 'coral'
/cvmfs/cms-ib.cern.ch/nweek-02463/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_0_X_2017-03-15-1100/src/CondTools/L1Trigger/interface/OMDSReader.h:57:44: error: template argument 1 is invalid
const std::vector< coral::AttributeList >& attLists )
|
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
@cmsbuild please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
…sented to the L1-phase II workshop Dec 2016