Online DQM changes for MWGR#2 #17696
Conversation
|
A new Pull Request was created by @cmsbuild for master. It involves the following packages: DQM/Integration @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
|
I can't edit the description anymore. The summary of changes is:
|
|
Comparison job queued. |
|
Hi @dmitrijus -what is DQMStreamerOutputRepacker.cc meant to be used for? |
|
Hi, as stated in the previous comment:
|
|
Hi @dmitrijus - thanks I missed it - could you add the phrase "Test" into the plugin name so that its clear? Thanks- |
|
Is that really necessary? It exists in "test/" and compiles into DQMServicesStreamerIOTestPlugins... |
nSigmaZ and beamSpot parameters do not exist in process.pixelTracksTrackingRegions, so _copy function did not skip anything. However, these parameters must be skipped, otherwise the client fails with: ----- Begin Fatal Exception 01-Mar-2017 10:33:02 CET----------------------- An exception of category 'Configuration' occurred while [0] Constructing the EventProcessor [1] Validating configuration of module: class=GlobalTrackingRegionEDProducer label='pixelTracksTrackingRegions' Exception Message: Illegal parameters found in configuration. The parameters are named: 'beamSpot' 'nSigmaZ' You could be trying to use parameter names that are not allowed for this plugin or they could be misspelled. ----- End Fatal Exception -------------------------------------------------
dmitrijus
force-pushed
the
mwgr2_changes
branch
from
d872c1b
to
630b4ed
Compare
|
Pull request #17696 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
|
Reordered commits and removed the pixel client config, which was causing the conflict. Should be mergable to both branches. |
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
|
Comparison job queued. |
|
+1 |
Work in progress...
Automatically ported from CMSSW_9_0_X #17660 (original by @dmitrijus).
Please wait for a new IB (12 to 24H) before requesting to test this PR.