[90X] Allow multi-IOV input for Millepede alignment framework #17724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move subtask into dedicated methods -> first step needed for unification -> also needed for support of multi-IOV input tag
- still enforce it in case no output IOVs are specified - adapt MPS to handle multi-IOV inputs properly
- split up input db creation in separate functions - propagate this change to stand-alone input creation script
- no functional change - just added missing configuration parameters which are deactivated for PCL
Make the method non-virtual because it acts like a constructor applied on an already constructed object. Since a constructor is always non-virtual it appears to be cleanest to declare also the 'update' methods non-virtual.
|
please test |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-notrun
tests-rejected
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
same observation and content as #17475 |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes shortcoming of the alignment framework which has not been able to update the alignables after an update of the tracker geometry at an IOV boundary.
Removes also temporary fix of #16135 and enables the usage of multi-IOV input for Millepede.
Added various protection against misconfiguration.
The code has been used to derive the 2016 legacy alignment.
The general AlignmentProducer has the new features disabled by default. It is only enabled for Millepede. If other alignment algorithms want to use it a flag has to be set to
True:The code is based on top of #17408, i.e. to better digest the changes, it might be useful to first review and eventually approve #17408.
EDIT: A dedicated presentation on this update has been given at the Tracker Alignment meeting on 01-Mar-2017
Automatically ported from CMSSW_9_0_X #17475 (original by @ghellwig).
Please wait for a new IB (12 to 24H) before requesting to test this PR.