Fix MultiTrackValidator sim dxy/dz wrt. PV histograms #17788
Conversation
…rackingParticle Earlier the dxy/dz were implicitly calculated wrt. BeamSpot as the TrackingParticle PCA vertex was shifted by the BS position in (Cosmic)ParametersDefinerForTP. When I added dxy/dz vs. PV, I didn't realize this, and thefore the current MTV dxy/dz are actuall wrt (BS-PV). Here the reference position is made explicit also for TrackingParticles, as is already the case for Tracks. Helper functions are added to reduce copy-paste.
Does not affect results (noticeably, at least). It would be easy to remove sin/cos from dxy as well, but those will change results a bit, so I leave it for later.
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: RecoMuon/MuonIdentification @perrotta, @civanch, @mdhildreth, @dmitrijus, @cmsbuild, @slava77, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
Comparison job queued. |
|
+1 |
|
+1 |
There was a bug in how the dxy and dz wrt. PV were calculated for TrackingParticles in
MultiTrackValidator. It did not take into account the fact that the position of point of closest approach to beamline (PCA) returned byParemtersDefinerTPshifted by the beamspot position, leading to biases in dxy and dz wrt. PV (most noticeably ~1 cm shift in dz). This PR suggests to fix this problem by making the calculation of dxy and dz more uniform between Track and TrackingParticle:ParametersDefinerTPleaves the PCA position to be wrt. (0,0,0) (as is Track reference point)reco::TrackBase, dealing with that is left to a later exercise)Tested in 9_0_0_pre4, expecting changes in MTV sim dxy and dz wrt. PV histograms (should be better centered around 0 now).
@rovere @VinInn