Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-sim04 Adding a dumping analyzer to diagnose if o/p is created using TestNumbering or not for HCAL #17800

Merged
merged 2 commits into from Mar 9, 2017

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Mar 6, 2017

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4CMS/Calo

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 6, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18181/console Started: 2017/03/06 22:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

@civanch
Copy link
Contributor

civanch commented Mar 7, 2017

@bsunanda , it is not possible to left even in a test a reference to a private file:
file:/afs/cern.ch/user/a/amkalsi/public/ForSunandaDa/024A536E-48EE-E611-843A-001E67E71C95.root

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Pull request #17800 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

bsunanda commented Mar 7, 2017

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18218/console Started: 2017/03/07 16:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2017

@civanch
Copy link
Contributor

civanch commented Mar 8, 2017

+1
@bsunanda , in the same test directory there are many other tests which use as an input a simple name like "testMuon.root", "zee.root".... These test files are generated at previous steps or may be link somehow. Having these two concrete names left in this new test would be a problem in a long term.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit b17f5c6 into cms-sw:master Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants