Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extention of neutron background simulation #17833

Merged
merged 1 commit into from Mar 10, 2017

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Mar 8, 2017

This is a clone of #17799.

By request of muon upgrade TDR, thermal neutron simulation extended two another Physics List used for this study. Time window extended from 0.1 second to 10 second. The common part of this customisation is moved to a separate fragment.

Comments to custom fragments are added.

Added extra header which will be used soon.

Should not affect mainstream simulation.

Preliminary results are reported at: https://indico.cern.ch/event/619427/contributions/2500420/attachments/1423597/2183273/Schnaible_CSC-GIF-WM_NeutronBkg-Comparison_7Mar2017_v3.pdf

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/Application
SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@civanch
Copy link
Contributor Author

civanch commented Mar 8, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18256/console Started: 2017/03/08 18:46

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

-1

Tested at: 8f5ccbf

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1cdb34b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17833/18256/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17833/18256/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17833/18256/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
10021.0 step4

runTheMatrix-results/10021.0_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step4_TenMuE_0_200+TenMuE_0_200_pythia8_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1cdb34b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17833/18256/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17833/18256/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2017

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@civanch
Copy link
Contributor Author

civanch commented Mar 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18273/console Started: 2017/03/09 10:26

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

Comparison job queued.

@civanch
Copy link
Contributor Author

civanch commented Mar 9, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

@davidlange6
Copy link
Contributor

Hi @civanch - thanks for the changes- I realize I forgot to ask what the impact is on SIM if these customize functions are used? Do you have some example timing information?

@civanch
Copy link
Contributor Author

civanch commented Mar 9, 2017

@davidlange6 , I have added a link to the talk with preliminary results to the PR description. There is a request to have different fragments for this study.

@davidlange6
Copy link
Contributor

thanks - was interested also in technical performance? Is there a drastic increase in time?

@civanch
Copy link
Contributor Author

civanch commented Mar 10, 2017

If we enable thermal neutrons the time per event increase in several times. The time for simplest mode (XS) is reasonable.

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 10, 2017 via email

@davidlange6
Copy link
Contributor

davidlange6 commented Mar 10, 2017 via email

@cmsbuild cmsbuild merged commit 5cbdfce into cms-sw:master Mar 10, 2017
@civanch
Copy link
Contributor Author

civanch commented Mar 10, 2017

What make it easier is that only MibBias WF is needed for this study, it is ~6 time slower than ttbar. So, extra factor of slow down is compensated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants