Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatacqProduce: added support for multiple matacq files per run #17869

Merged

Conversation

grasph
Copy link
Contributor

@grasph grasph commented Mar 9, 2017

Resubmission of pull-reques #17866 to branch "master" as recommended by the automatic message from cmsbuild.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

A new Pull Request was created by @grasph (Philippe Gras) for master.

It involves the following packages:

EventFilter/EcalRawToDigi

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @argiro this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 9, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18311/console Started: 2017/03/09 22:32

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17869/18311/summary.html

There are some workflows for which there are errors in the baseline:
25.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@slava77
Copy link
Contributor

slava77 commented Mar 13, 2017

assign alca

this affects laser calibrations and not reco workflows directly

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@mmusich,@cerminar,@arunhep,@franzoni,@ghellwig you have been requested to review this Pull request/Issue and eventually sign? Thanks

@franzoni
Copy link

Hello @slava77
We take note of this change.
Reading the code we see no evident issues.
However we can't assess the correctness of the details ( not familiar nor responsible for dataformat and the multi-file management logic )

@franzoni
Copy link

+1

@perrotta
Copy link
Contributor

+1
According to authors "The code which was updated is used on the ECAL laser monitoring farm located at P5. It is not used in neither in the reconstruction nor the simulation." In fact, no effect on reco is seen

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a43bd19 into cms-sw:master Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants