Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HCAL method 3 respons to 1.0 for data and MC. #17872

Merged
merged 1 commit into from Mar 14, 2017

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 9, 2017

Assume that retuning the pulse shapes will give the same response for Method 2 and Method 3, both for data and MC.

Assume that retuning the pulse shapes will give the same response
for Method 2 and Method 3, both for data and MC.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HLTrigger/Configuration
RecoLocalCalo/HcalRecProducers

@perrotta, @cmsbuild, @silviodonato, @fwyzard, @Martin-Grunewald, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mariadalfonso, @geoff-smith, @jalimena this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 9, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18314/console Started: 2017/03/09 23:34

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 9, 2017

Note that this does not change the value used in the HLT menus.
Those should be changed independently, via CMSHLT-1212, and the merged in the release.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17872/18314/summary.html

There are some workflows for which there are errors in the baseline:
25.0 step 5
10024.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

@Martin-Grunewald
Copy link
Contributor

+1

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 13, 2017

Please merge.

@perrotta
Copy link
Contributor

+1
The 5% scale increase configured with this PR is visible in the MC RecHit energies for Method3, e.g. https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_9_1_X_2017-03-09-1100+17872/18710/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/HcalRecHitsD_HcalRecHitTask.html
Since

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8b56735 into cms-sw:master Mar 14, 2017
@fwyzard fwyzard deleted the set_respCorrM3_to_1.0_91x branch July 11, 2017 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants