fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels #17886

franzoni · 2017-03-10T15:44:51Z

This PR is incremental with respect to this other one #17649 ; differences are updated further down in this conversation (since more commits have been added);
there the differences are described with respect to such PR.

…nels

cmsbuild · 2017-03-10T15:45:26Z

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_9_0_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

arunhep · 2017-03-10T15:57:32Z

please test

cmsbuild · 2017-03-10T15:58:25Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18342/console Started: 2017/03/10 21:10

cmsbuild · 2017-03-10T21:53:57Z

+1
Tested at: f6f60c3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17886/18342/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
553f7be
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17886/18342/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17886/18342/git-merge-result

cmsbuild · 2017-03-10T21:54:00Z

Comparison job queued.

cmsbuild · 2017-03-11T01:13:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17886/18342/summary.html

franzoni · 2017-03-12T19:22:19Z

phaseI MC 2017:

the change in geometry is expected to scatter differences widely, due to its impact on the pseudorandom number sequences
low level Sistrip plots hightly segmented -> can't see effect of the channel status changes over the 10 available events (plus the previous bullet)
HCAL vs eta hit occupancies are the same or compatible (the emap change is expected to have no effect on digi/rehits)

phaseI MC 2018:

same picture as 2017

phaseII MC:

the change in channel status is not picked up by the Phase2OuterTracker plots . Tracking is also totally unaffected ( what impact to we expect ? @mmusic @dimattia )

2016B

differences in JEtMEt, Btag Physics ParticleFlow Btag Physics ParticleFlow -> as expected given the no extra change with respect to GT updates for 900pre5 with Summer16 JECs, GEM reco geometry and ESEE Intercalib #17649

mmusich · 2017-03-12T19:52:46Z

@franzoni, my gitHub tag is @mmusich...
Coming to your question, I believe we expect (and see) no difference from the bad components change in 2023 workflows. I would be surprised of the contrary, given the geometry is completely different. I am expecting that at this level of development, OT conditions are hardwired. @boudoul to comment more. I suggested those to be included in the GT queue, as we already discussed verbally, for your own convenience, to ease the comparison with 2017 MC.

boudoul · 2017-03-12T20:03:35Z

I'm not expecting changes in phase2 , or better : I do not want to see changes in phase2

franzoni · 2017-03-12T21:10:29Z

Thanks @mmusich @boudul for the inputs

cmsbuild · 2017-03-18T06:34:42Z

Pull request #17886 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

franzoni · 2017-03-18T06:34:54Z

please test

cmsbuild · 2017-03-18T06:34:55Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18536/console Started: 2017/03/18 07:35

franzoni · 2017-03-18T06:50:05Z

This PR is incremental with respect to this other one #17649 ; differences are described with respect to such PR. This description includes all the commits up to this point.

Summary of changes in Global Tags

Data

runI and runII data : 90X_dataRun2_v6 as 90X_dataRun2_v5 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note
runII data relval : 90X_dataRun2_relval_v6 as 90X_dataRun2_relval_v5 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note
runII data prompt-like : 90X_dataRun2_PromptLike_v6 as 90X_dataRun2_PromptLike_v5 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note
runI and runII HLT : 90X_dataRun2_HLT_frozen_v4 as 90X_dataRun2_HLT_frozen_v3 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note
runI and runII HLT relval : 90X_dataRun2_HLT_relval_v4 as 90X_dataRun2_HLT_relval_v3 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note
runII HLT HI : 90X_dataRun2_HLTHI_frozen_v4 as 90X_dataRun2_HLTHI_frozen_v3 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note

Upgrade

PhaseII realistic scenario : 90X_upgrade2023_realistic_v9 as 90X_upgrade2023_realistic_v6 with the following changes:
- removed unnecessary geometry records
- sistrip bad components
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout (fix), ES calibration - https://indico.cern.ch/event/615692/contributions/2484421/
PhaseI 2017 cosmics peak scenario : 90X_upgrade2017cosmics_realistic_peak_v19 as 90X_upgrade2017cosmics_realistic_peak_v15 with the following changes:
- updated geometry (fix GEM passive volume)
- HcalElectronicsMap
- HcalRespCorrs 1 -> 1.05
- Bug Fix in HCAL LUTs described and HCAL Response Correction Update details here
- sistrip bad components
- beamstpot consistenet w/ alignement
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout (fix), ES calibration -
- Drift tubes alignment and alignment errors
PhaseI 2017 cosmics scenario : 90X_upgrade2017cosmics_realistic_deco_v18 as 90X_upgrade2017cosmics_realistic_peak_v15 with the following changes:
- updated geometry (fix GEM passive volume)
- HcalElectronicsMap
- HcalRespCorrs 1 -> 1.05
- Bug Fix in HCAL LUTs described and HCAL Response Correction Update details here
- sistrip bad components
- beamstpot consistenet w/ alignement
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout (fix), ES calibration -
- Drift tubes alignment and alignment errors
PhaseI 2017 design scenario : 90X_upgrade2017_design_IdealBS_v19 as 90X_upgrade2017_design_IdealBS_v16 with the following changes:
- updated geometry (fix GEM passive volume)
- HcalElectronicsMap
- HcalRespCorrs 1 -> 1.05
- Bug Fix in HCAL LUTs described and HCAL Response Correction Update details here
PhaseI 2017 realistic scenario : 90X_upgrade2017_realistic_v20 as 90X_upgrade2017_realistic_v16 with the following changes:
- updated geometry (fix GEM passive volume)
- HcalElectronicsMap
- HcalRespCorrs 1 -> 1.05
- Bug Fix in HCAL LUTs described and HCAL Response Correction Update details here
- sistrip bad components
- beamstpot consistenet w/ alignement
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout (fix), ES calibration -
- Drift tubes alignment and alignment errors
PhaseI 2018 cosmics scenario : 90X_upgrade2018cosmics_realistic_deco_v17 as 90X_upgrade2018cosmics_realistic_peak_v12 with the following changes:
- updated geometry (fix GEM passive volume and HCAL changes from code)
- HcalElectronicsMap
- Bug Fix in HCAL LUTs described and HCAL Response Correction Update details here
- sistrip bad components
- sistrip noise switched from peak to DECO (the new default)
- beamstpot consistenet w/ alignement
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout (fix), ES calibration -
- Drift tubes alignment and alignment errors
PhaseI 2018 design scenario : 90X_upgrade2018_design_IdealBS_v15 as 90X_upgrade2018_design_IdealBS_v13 with the following changes:
- updated geometry (fix GEM passive volume and HCAL changes from code)
- HcalElectronicsMap
- Bug Fix in HCAL LUTs described and HCAL Response Correction Update details here
PhaseI 2018 realistic scenario : 90X_upgrade2018_realistic_v17 as 90X_upgrade2018_realistic_v13 with the following changes:
- updated geometry (fix GEM passive volume and HCAL changes from code)
- HcalElectronicsMap
- Bug Fix in HCAL LUTs described and HCAL Response Correction Update details here
- sistrip bad components
- beamstpot consistenet w/ alignement
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout (fix), ES calibration -
- Drift tubes alignment and alignment errors

cmsbuild · 2017-03-18T09:34:49Z

+1
Tested at: 074e25f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17886/18536/summary.html

cmsbuild · 2017-03-18T09:34:52Z

Comparison job queued.

cmsbuild · 2017-03-18T11:22:57Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17886/18536/summary.html

franzoni · 2017-03-19T05:00:30Z

https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2860/1/1/1/2/1/1/1/1.html

franzoni · 2017-03-19T22:22:17Z

Latest update related to hcal trigger primitives discussed here #17975 (comment)

franzoni · 2017-03-19T22:22:27Z

+1

cmsbuild · 2017-03-19T22:22:35Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

davidlange6 · 2017-03-20T09:39:25Z

+1

franzoni · 2017-03-20T09:45:24Z

hello @davidlange6 @ianna
we take note of #17978 (comment)
cheers, G.

arunhep and others added 5 commits February 27, 2017 23:08

GT updates for 900pre5

a6c3f64

GTs updated

744d514

Run-2 MC Startup reverted back to 50ns JECs

bce7d1f

Merged refs/pull/17649/head from repository cms-sw

553f7be

fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad chan…

f6f60c3

…nels

cmsbuild added this to the Next CMSSW_9_0_X milestone Mar 10, 2017

cmsbuild added alca-pending comparison-pending orp-pending pending-signatures tests-pending labels Mar 10, 2017

franzoni changed the title ~~Gf deploy dpgpogmc campaing cmssw 9 0 x 2017 03 01 2300~~ fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels Mar 10, 2017

This was referenced Mar 10, 2017

Setting up properly peak and deco (strip tracker config) 2017 cosmic WFs #17829

Merged

Setting up properly peak and deco (strip tracker config) 2017 cosmic WFs #17828

Merged

cmsbuild added tests-started and removed tests-pending labels Mar 10, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 10, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 11, 2017

cmsbuild added the tests-pending label Mar 18, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 18, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 18, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 18, 2017

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Mar 19, 2017

This was referenced Mar 19, 2017

bsunanda:Run2-hcx118 Backport bug fix (as in PR 17773) #17978

Merged

bsunanda:Run2-hcx115 Correct the issue of ieta=29 for higher depths in the Phase1 mode #17773

Merged

cmsbuild added orp-approved and removed orp-pending labels Mar 20, 2017

cmsbuild merged commit 9153511 into cms-sw:CMSSW_9_0_X Mar 20, 2017

davidlange6 mentioned this pull request Mar 24, 2017

Fix bug in L1tMuonProducer #18063

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels #17886

fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels #17886

franzoni commented Mar 10, 2017 •

edited

cmsbuild commented Mar 10, 2017

arunhep commented Mar 10, 2017

cmsbuild commented Mar 10, 2017 •

edited

cmsbuild commented Mar 10, 2017

cmsbuild commented Mar 10, 2017

cmsbuild commented Mar 11, 2017

franzoni commented Mar 12, 2017 •

edited

mmusich commented Mar 12, 2017

boudoul commented Mar 12, 2017

franzoni commented Mar 12, 2017

cmsbuild commented Mar 18, 2017

franzoni commented Mar 18, 2017

cmsbuild commented Mar 18, 2017 •

edited

franzoni commented Mar 18, 2017

cmsbuild commented Mar 18, 2017

cmsbuild commented Mar 18, 2017

cmsbuild commented Mar 18, 2017

franzoni commented Mar 19, 2017

franzoni commented Mar 19, 2017

franzoni commented Mar 19, 2017

cmsbuild commented Mar 19, 2017

davidlange6 commented Mar 20, 2017

franzoni commented Mar 20, 2017

fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels #17886

fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels #17886

Conversation

franzoni commented Mar 10, 2017 • edited

cmsbuild commented Mar 10, 2017

arunhep commented Mar 10, 2017

cmsbuild commented Mar 10, 2017 • edited

cmsbuild commented Mar 10, 2017

cmsbuild commented Mar 10, 2017

cmsbuild commented Mar 11, 2017

franzoni commented Mar 12, 2017 • edited

mmusich commented Mar 12, 2017

boudoul commented Mar 12, 2017

franzoni commented Mar 12, 2017

cmsbuild commented Mar 18, 2017

franzoni commented Mar 18, 2017

cmsbuild commented Mar 18, 2017 • edited

franzoni commented Mar 18, 2017

Summary of changes in Global Tags

Data

Upgrade

cmsbuild commented Mar 18, 2017

cmsbuild commented Mar 18, 2017

cmsbuild commented Mar 18, 2017

franzoni commented Mar 19, 2017

franzoni commented Mar 19, 2017

franzoni commented Mar 19, 2017

cmsbuild commented Mar 19, 2017

davidlange6 commented Mar 20, 2017

franzoni commented Mar 20, 2017

franzoni commented Mar 10, 2017 •

edited

cmsbuild commented Mar 10, 2017 •

edited

franzoni commented Mar 12, 2017 •

edited

cmsbuild commented Mar 18, 2017 •

edited