fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels [91x version] #17905

franzoni · 2017-03-13T14:29:25Z

This PR will lead to the same set of GT's in 91X as this other PR #17886 in do in 90x

Since in 91x, a set of updates
("Summer16 JECs, GEM reco geometry and ESEE Intercalib" - see PR #17702 ; the equivalent 90x #17649 is yet to be merged )
has already been merged,
the changes expected in this PR are fewer than have been observed for the 90x #17886

The changes expected are described in the further down in this chat, since commits have been added

…nels

cmsbuild · 2017-03-13T14:30:11Z

A new Pull Request was created by @franzoni (Giovanni Franzoni) for master.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @ghellwig, @tocheng this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

franzoni · 2017-03-13T14:39:14Z

please test

cmsbuild · 2017-03-13T14:39:29Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18365/console Started: 2017/03/13 19:51

cmsbuild · 2017-03-13T20:04:03Z

+1
Tested at: 015b97d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17905/18365/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
015b97d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17905/18365/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17905/18365/git-merge-result

cmsbuild · 2017-03-13T20:04:06Z

Comparison job queued.

cmsbuild · 2017-03-13T21:22:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17905/18365/summary.html

cmsbuild · 2017-03-13T23:17:44Z

Pull request #17905 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

franzoni · 2017-03-13T23:23:10Z

please test

cmsbuild · 2017-03-13T23:24:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18381/console Started: 2017/03/14 01:03

franzoni · 2017-03-13T23:24:54Z

This PR will lead to the same set of GT's in 91X as this other PR #17886 in do in 90x

Since in 91x, a set of updates
("Summer16 JECs, GEM reco geometry and ESEE Intercalib" - see PR #17702 ; the equivalent 90x #17649 is yet to be merged )
has already been merged,
the changes expected in this PR are fewer than have been observed for the 90x #17886

The changes expected are described in the following

Summary of changes in Global Tags

Data

runI and runII data : 90X_dataRun2_v6 as 90X_dataRun2_v5 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note
runII data relval : 90X_dataRun2_relval_v6 as 90X_dataRun2_relval_v5 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note
runII data prompt-like : 90X_dataRun2_PromptLike_v6 as 90X_dataRun2_PromptLike_v5 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note
runI and runII HLT : 90X_dataRun2_HLT_frozen_v4 as 90X_dataRun2_HLT_frozen_v3 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note
runI and runII HLT relval : 90X_dataRun2_HLT_relval_v4 as 90X_dataRun2_HLT_relval_v3 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note
runII HLT HI : 90X_dataRun2_HLTHI_frozen_v4 as 90X_dataRun2_HLTHI_frozen_v3 with the following changes:
- the GEM reco geometry is only available for 2017 runs (>= 287446); please @ianna take note

Upgrade

PhaseII realistic scenario : 90X_upgrade2023_realistic_v8 as 90X_upgrade2023_realistic_v6 with the following changes:
- removed unnecessary geometry records
- sistrip bad components https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2837.html
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout, ES calibration - https://indico.cern.ch/event/615692/contributions/2484421/
PhaseI 2017 cosmics peak scenario : 90X_upgrade2017cosmics_realistic_peak_v17 as 90X_upgrade2017cosmics_realistic_peak_v15 with the following changes:
- updated geometry (fix GEM passive volume) https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2841.html
- HcalElectronicsMap https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2838.html
- HcalRespCorrs 1 -> 1.05 https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2843.html
- sistrip bad components https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2837.html
- beamstpot consistenet w/ alignement https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2852.html
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout, ES calibration - https://indico.cern.ch/event/615692/contributions/2484421/
- Drift tubest alignment and alignmenet errors https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2851.html
PhaseI 2017 cosmics scenario : 90X_upgrade2017cosmics_realistic_deco_v16 as 90X_upgrade2017cosmics_realistic_peak_v15 with the following changes:
- updated geometry (fix GEM passive volume) https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2841.html
- HcalElectronicsMap https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2838.html
- HcalRespCorrs 1 -> 1.05 https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2843.html
- sistrip bad components https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2837.html
- beamstpot consistenet w/ alignement https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2852.html
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout, ES calibration - https://indico.cern.ch/event/615692/contributions/2484421/
- Drift tubest alignment and alignmenet errors https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2851.html
PhaseI 2017 design scenario : 90X_upgrade2017_design_IdealBS_v18 as 90X_upgrade2017_design_IdealBS_v16 with the following changes:
- updated geometry (fix GEM passive volume) https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2841.html
- HcalElectronicsMap https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2838.html
- HcalRespCorrs 1 -> 1.05 https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2843.html
PhaseI 2017 realistic scenario : 90X_upgrade2017_realistic_v18 as 90X_upgrade2017_realistic_v16 with the following changes:
- updated geometry (fix GEM passive volume) https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2841.html
- HcalElectronicsMap https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2838.html
- HcalRespCorrs 1 -> 1.05 https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2843.html
- sistrip bad components https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2837.html
- beamstpot consistenet w/ alignement https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2852.html
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout, ES calibration - https://indico.cern.ch/event/615692/contributions/2484421/
- Drift tubest alignment and alignmenet errors https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2851.html
PhaseI 2018 cosmics scenario : 90X_upgrade2018cosmics_realistic_deco_v15 as 90X_upgrade2018cosmics_realistic_peak_v12 with the following changes:
- updated geometry (fix GEM passive volume and HCAL changes from code) https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2842.html
- HcalElectronicsMap https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2838.html
- sistrip bad components https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2837.html
- sistrip noise switched from peak to DECO (the new default)
- beamstpot consistenet w/ alignement https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2852.html
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout, ES calibration - https://indico.cern.ch/event/615692/contributions/2484421/
- Drift tubest alignment and alignmenet errors https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2851.html
PhaseI 2018 design scenario : 90X_upgrade2018_design_IdealBS_v14 as 90X_upgrade2018_design_IdealBS_v13 with the following changes:
- updated geometry (fix GEM passive volume and HCAL changes from code) https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2842.html
- HcalElectronicsMap https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2838.html
PhaseI 2018 realistic scenario : 90X_upgrade2018_realistic_v15 as 90X_upgrade2018_realistic_v13 with the following changes:
- updated geometry (fix GEM passive volume and HCAL changes from code) https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2842.html
- HcalElectronicsMap https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2838.html
- sistrip bad components https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2837.html
- beamstpot consistenet w/ alignement https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2852.html
- ECAL: 2017 predictions for channel status, APD/Pn and alphas, pedestal, Trigger Primitives, selective readout, ES calibration - https://indico.cern.ch/event/615692/contributions/2484421/
- Drift tubest alignment and alignmenet errors https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/2851.html

cmsbuild · 2017-03-14T01:48:12Z

+1
Tested at: ece771b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17905/18381/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
015b97d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17905/18381/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17905/18381/git-merge-result

cmsbuild · 2017-03-14T01:48:14Z

Comparison job queued.

cmsbuild · 2017-03-14T04:10:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17905/18381/summary.html

franzoni · 2017-03-14T11:14:04Z

phaseI MC 2017:

the change in geometry is expected to scatter differences widely, due to its impact on the pseudorandom number sequences
low level Sistrip plots hightly segmented -> can't see effect of the channel status changes over the 10 available events (plus the previous bullet)
HCAL vs eta hit occupancies are the same or compatible (the emap change is expected to have no effect on digi/rehits)
change in occupancy clear in EB, as a result of SelRead and Transparency/Pedestal changes

phaseI MC 2018:

same picture as 2017

phaseII MC:

the change in channel status is not picked up by the Phase2OuterTracker plots . Tracking is also totally unaffected --> expected

data:

2012B and 2016B unaffected by replacing for GEM reco geometry the IOV 1-inf with 287446-inf

franzoni · 2017-03-14T11:14:08Z

+1

cmsbuild · 2017-03-14T11:14:22Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

Giovanni Franzoni added 3 commits March 10, 2017 12:06

Merged refs/pull/17649/head from repository cms-sw

553f7be

fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad chan…

f6f60c3

…nels

Merged refs/pull/17886/head from repository cms-sw

015b97d

cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 13, 2017

cmsbuild added alca-pending comparison-pending orp-pending pending-signatures tests-pending labels Mar 13, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 13, 2017

franzoni mentioned this pull request Mar 13, 2017

GT updates for 900pre5 with Summer16 JECs, GEM reco geometry and ESEE Intercalib #17649

Closed

cmsbuild added tests-approved and removed tests-started labels Mar 13, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 13, 2017

arunhep added 4 commits March 14, 2017 00:16

data GTs updated with fixed GEM reco tag

0d88469

MC Realistic GTs updated

0071538

Cosmic GT for 2018 updated

c881c48

Cosmic GT updated

ece771b

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Mar 13, 2017

cmsbuild added tests-started and removed tests-pending labels Mar 13, 2017

cmsbuild added tests-approved and removed tests-started labels Mar 14, 2017

cmsbuild added comparison-available and removed comparison-pending labels Mar 14, 2017

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Mar 14, 2017

davidlange6 merged commit d821832 into cms-sw:master Mar 14, 2017

boudoul mentioned this pull request Mar 14, 2017

Setting up properly peak and deco (strip tracker config) 2017 cosmic WFs #17828

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels [91x version] #17905

fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels [91x version] #17905

franzoni commented Mar 13, 2017 •

edited

cmsbuild commented Mar 13, 2017

franzoni commented Mar 13, 2017

cmsbuild commented Mar 13, 2017 •

edited

cmsbuild commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

franzoni commented Mar 13, 2017

cmsbuild commented Mar 13, 2017 •

edited

franzoni commented Mar 13, 2017 •

edited

cmsbuild commented Mar 14, 2017

cmsbuild commented Mar 14, 2017

cmsbuild commented Mar 14, 2017

franzoni commented Mar 14, 2017

franzoni commented Mar 14, 2017

cmsbuild commented Mar 14, 2017

fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels [91x version] #17905

fix GEM geometry - HCAL emap - HCAL resoCorr HEP17 - SiStrip bad channels [91x version] #17905

Conversation

franzoni commented Mar 13, 2017 • edited

cmsbuild commented Mar 13, 2017

franzoni commented Mar 13, 2017

cmsbuild commented Mar 13, 2017 • edited

cmsbuild commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

cmsbuild commented Mar 13, 2017

franzoni commented Mar 13, 2017

cmsbuild commented Mar 13, 2017 • edited

franzoni commented Mar 13, 2017 • edited

Summary of changes in Global Tags

Data

Upgrade

cmsbuild commented Mar 14, 2017

cmsbuild commented Mar 14, 2017

cmsbuild commented Mar 14, 2017

franzoni commented Mar 14, 2017

franzoni commented Mar 14, 2017

cmsbuild commented Mar 14, 2017

franzoni commented Mar 13, 2017 •

edited

cmsbuild commented Mar 13, 2017 •

edited

cmsbuild commented Mar 13, 2017 •

edited

franzoni commented Mar 13, 2017 •

edited