Revert "Merge pull request #17175 from pietverwilligen/90X_NewME0GeometryBuilder_ForPR_v1" (only for L1 TDR production) [90X]

[kpedro88]

CMSSW_9_0_0 is planned to be used for the Phase2 L1Trigger TDR MC production. For expediency, we prefer to reuse existing GEN-SIM from the Phase2 Tracker TDR production, rerunning only the DIGI step. In order to have a compatible release, a change in the ME0 geometry (PR #17175) must be reverted. (The new improved ME0 geometry will be retained in CMSSW_9_1_X for further development and other future TDR productions.)

attn: @rekovic, @calabria, @jshlee, @pietverwilligen, @davidlange6, @mdhildreth

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_0_X.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/GEMGeometry
Geometry/GEMGeometryBuilder
Geometry/MuonCommonData
Geometry/MuonNumbering

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18374/console Started: 2017/03/13 21:05

[cmsbuild]

-1

Tested at: 920943f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17911/18374/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test test2023Geometry had ERRORS

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17911/18374/summary.html

[kpedro88]

Apparently the D11 detector was added after #17175 was merged, so reverting it did not fix that XML config. Good thing I added the unit test...

[kpedro88]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18379/console Started: 2017/03/13 23:28

[cmsbuild]

Pull request #17911 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88, @davidlange6 can you please check and sign again.

[cmsbuild]

+1
Tested at: 7052c48
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17911/18379/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17911/18379/summary.html

[ianna]

+1

[kpedro88]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[kpedro88]

@davidlange6 is 90X still being merged into 91X? I would like to avoid a "revert revert" PR to 91X...

[davidlange6]

we have never merged 90x into 91x

…

On Mar 14, 2017, at 3:30 PM, Kevin Pedro ***@***.***> wrote: @davidlange6 is 90X still being merged into 91X? I would like to avoid a "revert revert" PR to 91X... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[davidlange6]

+1