Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparisons used for unit tests #17937

Merged
merged 1 commit into from Mar 15, 2017
Merged

Fix comparisons used for unit tests #17937

merged 1 commit into from Mar 15, 2017

Conversation

Dr15Jones
Copy link
Contributor

Recent changes to the framework job report output broke unit tests which were comparing expected reports to actual reports.

@Dr15Jones
Fix comparisons used for unit tests
22dd669 
Recent changes to the framework job report output broke unit tests which were comparing expected reports to actual reports.
@cmsbuild cmsbuild added this to the Next CMSSW_9_1_X milestone Mar 14, 2017
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

IOPool/Common

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18430/console Started: 2017/03/14 22:58

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 22dd669
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17937/18430/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17937/18430/summary.html

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8aecab9 into cms-sw:master Mar 15, 2017
@Dr15Jones Dr15Jones deleted the fixUnitTestJobReport branch March 15, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available core-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @davidlange6