L1T BlockHeader changes for L1T ZS DQM

[thomreis]

Added the ZS validation flag to the L1T BlockHeader to be used with the online DQM zero suppression module.

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQM/L1TMonitor
EventFilter/L1TRawToDigi

@dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18499/console Started: 2017/03/16 17:52

[cmsbuild]

-1

Tested at: 27c81bc

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17956/18499/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[thomreis]

This segfault does not seem to have anything to do with the L1 code. Can we run the tests again please?

[rekovic]

Log from failing jobs 135.4 does not seem to point to this PR:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17956/18499/runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

will try test again.

[rekovic]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18511/console Started: 2017/03/17 10:45

[cmsbuild]

+1
Tested at: 27c81bc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17956/18511/summary.html

[cmsbuild]

Comparison job queued.

[dmitrijus]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-17956/18511/summary.html

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[thomreis]

Hi @Muzaffar, @davidlange6, @smuzaffar,
what is keeping this and #17958 from being merged?

[thomreis]

If there is a problem with this PR please let me know so that I can fix it. If not please merge it so that it can be in the next release deployed for the DQM at p5.

[thomreis]

@Muzaffar, @davidlange6, @smuzaffar can someone please tell me what keeps this from being merged? It is fully signed for a month now.

[rekovic]

@davidlange6
Please post your concerns. We should fix this for data taking. Thanks.

[rekovic]

Hi @davidlange6.
We should get this PR and #17958 ready for data taking.
Can we please get your explicit comments, so that we can address them efficiently.

[davidlange6]

i finally connected with @rekovic on this PR _ we agreed that in a followup PR that Block would go into a DataFormats package so that the usual CMS structure of data formats, producers, analyzers could be adopted

[davidlange6]

+1