Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-hcx118 Backport bug fix (as in PR 17773) #17978

Merged
merged 1 commit into from Mar 20, 2017

Conversation

bsunanda
Copy link
Contributor

Issue of ieta=29 in Plan 1 or Phase I HE geoemtry

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_9_0_X.

It involves the following packages:

Geometry/HcalCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18532/console Started: 2017/03/17 23:00

@kpedro88
Copy link
Contributor

urgent

@kpedro88
Copy link
Contributor

attn: @deguio

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@bsunanda
Copy link
Contributor Author

@ianna Please approve this

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 18, 2017

thanks @bsunanda and @kpedro88

@franzoni
Copy link

Hello all, does this fix need to enter the conditions update of 90 #17886 as well as 91 #17975 ?

@ianna
Copy link
Contributor

ianna commented Mar 20, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

Hi @franzoni - this looks to be only code changes, I presume no GT update is needed. but @ianna is best to confirm

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants