New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ROOT ImplicitMT through config #17999
Conversation
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: FWCore/Services @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
@@ -6,5 +6,6 @@ | |||
UnloadRootSigHandler = cms.untracked.bool(False), | |||
ResetRootErrHandler = cms.untracked.bool(True), | |||
AutoLibraryLoader = cms.untracked.bool(True), | |||
EnableIMT = cms.untracked.bool(True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dr15Jones Should I change this to False?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
Pull request #17999 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
does EnableimplicitMT() have the same behavior? That would be more clear. If not please document that this number is ignored.
… On Mar 21, 2017, at 1:37 PM, Patrick Gartung ***@***.***> wrote:
@gartung commented on this pull request.
In FWCore/Services/plugins/InitRootHandlers.cc:
> @@ -875,6 +875,10 @@ namespace edm {
if(debugLevel >0) {
gDebug = debugLevel;
}
+
+ // Enable Root implicit multi-threading
+ bool imt = pset.getUntrackedParameter<bool>("EnableIMT");
+ if (imt) ROOT::EnableImplicitMT(4);
Its a placeholder argument. It has no effect since the tbb system is already initialized.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
…ork handles the tbb initialization
Pull request #17999 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
+1 |
This enables ROOT IMT in CMSSW. It must be used with a build of ROOT with IMT enabled.