Pixel Phase 1 summary maps [90X]

[leggat]

Including the new summary maps for the phase 1 pixel detector in the 90X release.

[cmsbuild]

A new Pull Request was created by @leggat for CMSSW_9_0_X.

It involves the following packages:

DQM/SiPixelPhase1Config
DQM/SiPixelPhase1Summary

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[boudoul]

For the record, this is a backport of the master (already merged) PR : #17880

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18640/console Started: 2017/03/23 12:31

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[vanbesien]

Hey,
For the 9_0 which we are currently installing for Online, we got requests from tracker to manually put PR18028 and PR18017 on top of what was merged in 9_0.
If you want this PR on Online as well before it is merged in 9_0, please follow the normal procedure: Tag collector + contact us.

[fioriNTU]

@leggat please take the @vanbesien suggestion, we need this online

[cmsbuild]

+1
Tested at: 6590669
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18035/18640/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18035/18640/summary.html

[cmsbuild]

Pull request #18035 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

[dmitrijus]

Hi, if this is a backport from the master branch, please make sure it has the same commits as the PR to that master branch. This PR contains 50 lines less than the one in master.

[leggat]

Hi @dmitrijus - in fact this PR is more up-to-date than the merged one because of the bug fix introduced. I tried to make a new PR for 91X (#18146) to bring the merged code in line with this one, but it appears that 91X is now closed. How should I go about updating the already merged code?

[boudoul]

hi @leggat , 91X is not closed, it is just that it is the devlopment release and therefore you should make a PR to the default developement release called 'master ' which is the default queue when making a PR (and not choose 91X )

[leggat]

Ah sorry. Please find the new PR at #18148

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19106/console Started: 2017/04/11 17:19

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[cmsbuild]

+1
Tested at: be36277
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18035/19106/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18035/19106/summary.html

Comparison Summary:

• You potentially added 33 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1915960
• DQMHistoTests: Total failures: 29865
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1885922
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[davidlange6]

+1