Adding Timing vs BX plots, and modifying thresholds for laser quality

[tanmaymudholkar]

Companion to Deployment PR#455: dmwm/deployment#455

PR to CMSSW master: #18067

• Added new plots for the average partition timing v/s BX number.
• Changed expected values of laser timing from 4.2 clocks to 3.7 clocks for Laser 2. Also changed (the value of the deviation from the expected timing above which bad quality is triggered) to 1.0.

[cmsbuild]

A new Pull Request was created by @tanmaymudholkar (Tanmay Mudholkar) for CMSSW_9_0_X.

It involves the following packages:

DQM/EcalMonitorClient
DQM/EcalMonitorTasks

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[tanmaymudholkar]

Hi @davidlange6 , @dmitrijus , I wonder if we need to start the procedure (automated testing etc.) to get this merged with 90X.

Automated tests have already been run on the corresponding 91X version: #18067 , which now awaits ORP approval before merging.

In addition, thanks to some quick work by core DQM, this PR has already been applied as a patch onto the production version at P5.

[dmitrijus]

Hi @tanmaymudholkar, wait for until 91x is merged.

[cmsbuild]

Pull request #18069 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

[tanmaymudholkar]

I recently added a commit here to improve code readability. Please see the conversation in the 91X PR: #18067

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19108/console Started: 2017/04/11 17:27

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[cmsbuild]

+1
Tested at: d9e8ccf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18069/19108/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18069/19108/summary.html

Comparison Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 23
• DQMHistoTests: Total histograms compared: 1915960
• DQMHistoTests: Total failures: 44274
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 1871513
• DQMHistoTests: Total skipped: 173
• DQMHistoTests: Total Missing objects: 0
• Checked 94 log files, 14 edm output root files, 23 DQM output files

[davidlange6]

+1