Added pixel cluster ratio histograms

[pjurgielewicz]

Added plots in SiPixelPhase1Clusters needed for timing in collisions.

[cmsbuild]

A new Pull Request was created by @pjurgielewicz for master.

It involves the following packages:

DQM/SiPixelPhase1Clusters

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[dmitrijus]

Hi @fioriNTU, can you introduce @pjurgielewicz ?
The code looks otherwise okay.

[boudoul]

Hello @dmitrijus , sorry we should have done that indeed before .
@pjurgielewicz is our tracker technical student who is happily working for us during 2017 - Thanks

[dmitrijus]

+1

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18753/console Started: 2017/03/28 14:12

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[cmsbuild]

+1
Tested at: 271002b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18071/18753/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18071/18753/summary.html

[davidlange6]

Hi @pjurgielewicz @dmitrijus - these plots (sort of famous) are not already present elsewhere in CMSSW?

[pjurgielewicz]

Hi, similar plot is in SiStrip/MachanicalView/MainDiagonal Position. @fioriNTU could you justify the need for the new one in different location?

[fioriNTU]

@davidlange6 a slightly different set with basically the same information is in the SiStrip Mechanical view folder in DQM. However having them directly in the Pixel one would help expecially during the time alignment. Anyway these are not an exact copy of what is already available

[davidlange6]

maybe there is one for tracking too?:) - how many bins is this one? Its hard to see from the definition

…

On Apr 4, 2017, at 5:18 PM, fioriNTU ***@***.***> wrote: @davidlange6 a slightly different set with basically the same information is in the SiStrip Mechanical view folder in DQM. However having them directly in the Pixel one would help expecially during the time alignment. Anyway these are not an exact copy of what is already available — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[pjurgielewicz]

https://github.com/cms-sw/cmssw/pull/18071/files#diff-ce305008f3017255b54d1c5109243587R222

All introduced histograms have 100 bins.

[davidlange6]

+1
ok thanks - better to unify these in the long term..

[fioriNTU]

@davidlange6 these plots will be mainly used in the first period of data taking, there we may need to run privately on our online machine the Pixel client, so we need those plots in the Pixel DQM. After a few weeks we can disable them with any problem. Btw, I am not aware of such plots in the TrackingDQM.