Remove PV usage in packed gen particles

[alberto-sanchez]

This PR, cleans not used code, and makes the creation of MINIAODSIM from GEN-only samples easy.

[cmsbuild]

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @slava77, @monttj, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @JyothsnaKomaragiri this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[perrotta]

pleae test

[slava77]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18693/console Started: 2017/03/25 01:44

[cmsbuild]

-1

Tested at: ab2f746

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3857695
731b5c4
43c5e90
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18083/18693/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18083/18693/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18083/18693/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
3857695
731b5c4
43c5e90
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18083/18693/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18083/18693/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18083/18693/summary.html

[perrotta]

please test
(test failure seems unrelated to this PR)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18717/console Started: 2017/03/27 10:26

[gpetruc]

Hi Alberto,

Thanks for the PR.
Can you change the title to "Remove PV usage in packed gen particles" or something similar?
The current title is a bit confusing, as regular MINIAODSIM files do contain the reconstructed PVs.

Giovanni

[cmsbuild]

+1
Tested at: ab2f746
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18083/18717/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18083/18717/summary.html

[slava77]

+1

for #18083 ab2f746

• technical change removing unused code/branch, as described
• jenkins tests pass and comparisons show no differences