Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the number of ME0 phi-strips and adding the displaced muon validation #18091

Merged
merged 1 commit into from Mar 29, 2017

Conversation

calabria
Copy link
Contributor

With this PR we are changing the number of ME0 phi-strips from 512 to 384, given the latest simulation results presented during the Muon Workshop last week:

https://indico.cern.ch/event/614702/contributions/2519760/attachments/1432877/2201719/nmccoll_3_24_17_MuUpgWkshp.pdf

Moreover we need to restore the validation of the displaced muon reconstructions, to spot issues like the one that came out recently (slide 13):

https://indico.cern.ch/event/623423/contributions/2514930/subcontributions/222604/attachments/1428355/2192582/Upgrade_Performance_14032017.pdf

@pietverwilligen @jshlee @kpedro88

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @calabria (Cesare) for master.

It involves the following packages:

Geometry/GEMGeometryBuilder
Validation/RecoMuon

@civanch, @Dr15Jones, @ianna, @mdhildreth, @dmitrijus, @cmsbuild, @kpedro88, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @battibass, @abbiendi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ianna
Copy link
Contributor

ianna commented Mar 27, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18727/console Started: 2017/03/27 15:28

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@ianna
Copy link
Contributor

ianna commented Mar 27, 2017

+1

@dmitrijus
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@kpedro88
Copy link
Contributor

(we should probably add a D12 workflow to the short matrix...)

@davidlange6
Copy link
Contributor

happy to support D12 in the short matrix as long as it replaces something...

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9f41a2c into cms-sw:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants