Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctpps pixel unpacker #18103

Merged
merged 40 commits into from Apr 13, 2017
Merged

Ctpps pixel unpacker #18103

merged 40 commits into from Apr 13, 2017

Conversation

fabferro
Copy link
Contributor

release-notes:
in EventFilter/CTPPSTawToDigi CTPPSPixelRawToDigi algorithm to unpack raw data;
output is CTPPSPixelDigi's defined in DataFormats/CTPPSDigi/CTPPSPixelDigi;
in CondFormats/CTPPSReadoutObjects added the condition objects to retrieve the DAQ mapping, with corresponding DataRecord's;
at the moment DAQ mapping and channel masking are read via xml parsing;
DB access will be implemented asap;
inside CTPPSReadoutObjects/xml are 2 kinds of data files: those called *_220_far.xml for 2017 upcoming runs and *_TEST.xml for testbench runs in H8.
NOTE on names: RPix = CTPPSPixel

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

CondFormats/CTPPSReadoutObjects
CondFormats/DataRecord
DataFormats/CTPPSDigi
EventFilter/CTPPSRawToDigi

@perrotta, @ghellwig, @civanch, @arunhep, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @slava77, @ggovi, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ghellwig, @apfeiffer1, @tocheng this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@slava77
Copy link
Contributor

slava77 commented Mar 28, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 28, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18745/console Started: 2017/03/28 09:53

@fabferro
Copy link
Contributor Author

To test, run: EventFilter/CTPPSRawToDigi/test/test_pixels_only_cfg.py
Only data from lab available. Detector being installed now.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #18103 was updated. @perrotta, @ghellwig, @civanch, @arunhep, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @slava77, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #18103 was updated. @perrotta, @ghellwig, @civanch, @arunhep, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @slava77, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@fabferro
Copy link
Contributor Author

@davidlange6 I think I've pushed all files. Please check. Thanks!

@cmsbuild
Copy link
Contributor

Pull request #18103 was updated. @perrotta, @ghellwig, @civanch, @arunhep, @cerminar, @cmsbuild, @franzoni, @mdhildreth, @slava77, @ggovi, @mmusich, @davidlange6 can you please check and sign again.

@davidlange6
Copy link
Contributor

davidlange6 commented Apr 13, 2017 via email

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 13, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19165/console Started: 2017/04/13 13:49

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@davidlange6 davidlange6 merged commit 1f04ccd into cms-sw:master Apr 13, 2017
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18103/19165/summary.html

Comparison Summary:

  • You potentially added 3 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1689 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1921525
  • DQMHistoTests: Total failures: 20502
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1900850
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@slava77
Copy link
Contributor

slava77 commented Apr 13, 2017

+1
post-merge signoff
for #18103 94f4e85

  • changes in the code still work out on the test file with injected pixel data and show no difference in outputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants