Fix circular dependency between FWCore/Framework and FWCore/ParameterSet

[Dr15Jones]

Removed the unnecessary dependency of FWCore/ParameterSet on FWCore/Framework. No functionality was lost due to this change.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/MessageService
FWCore/Modules
FWCore/ParameterSet
FWCore/Services

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18775/console Started: 2017/03/29 11:00

[Dr15Jones]

NOTE: it is likely that this will cause problems with other code in CMSSW because that other code was getting needed header files implicitly rather than explicitly. I will fix those problems in this pull request once the testing finds them.

[cmsbuild]

-1

Tested at: 39a067c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18117/18775/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-28-2300/src/RecoJets/JetProducers/plugins/SubJetProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-28-2300/src/RecoJets/JetProducers/plugins/BasicToPFJet.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-28-2300/src/RecoJets/JetProducers/plugins/VirtualJetProducer.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-28-2300/src/RecoJets/JetProducers/plugins/CompoundJetProducer.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-28-2300/src/RecoJets/JetProducers/plugins/BasicToPFJet.cc: In member function 'virtual void BasicToPFJet::produce(edm::Event&, const edm::EventSetup&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-28-2300/src/RecoJets/JetProducers/plugins/BasicToPFJet.cc:53:8: error: invalid use of incomplete type 'class edm::Event'
   Event.getByToken(inputToken_, BasicJetColl);
        ^
In file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-28-2300/src/FWCore/Framework/interface/Principal.h:27:0,
                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-28-2300/src/FWCore/Framework/interface/EventPrincipal.h:23,
                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_1_X_2017-03-28-2300/src/FWCore/Framework/interface/OccurrenceTraits.h:13,


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[ghellwig]

+1

[Dr15Jones]

+1

[kpedro88]

+1

[civanch]

+1

[cmsbuild]

+1
Tested at: fdba05b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18117/18784/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18117/18784/summary.html

[perrotta]

+1
Reco signature needed because of addition of missing includes

[Dr15Jones]

@davidlange6 all the non-core labels are only there because I had to add missing header files.