Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr91x L1T integration v92.10 #18133

Merged
merged 53 commits into from Apr 19, 2017
Merged

Pr91x L1T integration v92.10 #18133

merged 53 commits into from Apr 19, 2017

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Mar 30, 2017 •
edited

91x L1T:

For successful testing, first need cms-data/L1Trigger-L1TMuon#9 external merged.

Comment:
Out of 39 files in this PR, there are 10 .py files which are used as customisations by calibrations developers and are not used as default.

This PR has recent developments in L1T integration up to v92.10,
with the following two reverts, in order to avoid duplication of existing PRs.

Reverted commits provided in two separate already existing PRs:

Main features:

  • uGMT Muons support for eta/phi vertex-extraopolated variables. Updates in DataFormat, Packer/Unpacker and uGMT emulator.
  • Various versions of CaloLayer1 calibrations configuration files (10 .py files used in customisation for experts). None of this files are used as default yet.

thomreis and others added 30 commits March 30, 2017 16:32
@thomreis @rekovic
Make FW algo version known to MuonUnpacker
4d96a6c
@thomreis @rekovic
Extend L1 muon data format with eta and phi coordinates propagated to…
6a0d244 
… the vertex
@thomreis @rekovic
Make fed number known to muon unpacker
6abde68
@thomreis @rekovic
L1 muon unpacker for 2017 RAW data format
044515d
@thomreis @rekovic
Add eta and phi coordinates at vertex to uGMT emulator
b0bff4f
@apana @rekovic
Update to read L1 prescales from dB
1e59c6d
@thomreis @rekovic
Calculate deltas from unpacked RAW
38d0733
@thomreis @rekovic
Adapt L1 ntuples to new muon data format
4fee17e
@thomreis @rekovic
setup new muonUnpacker in GTsetup
4bee157
@thomreis @rekovic
Set best estimate for FW version for switch to 2017 RAW format and fi…
c73a8b6 
…x a bug in the 2016 unpacking
@apana @rekovic
cfi for when running uGT emulator
040a5e5
@apana @rekovic
Update to dump tower counts
3b45254
@rekovic
Post conflict cleanup: remove duplicate function declaration.
82e3510
@rekovic
new params config including 2017.02.16 JEC in functional form
78564ac
@bundocka @rekovic
Emulator fix to prevent attempted calibration of saturated jets
f3c6b5c
@davignon @rekovic
First 2017 L1Tau LUTs
d88a5c9
@jbsauvan @rekovic
Add first 2017 eg LUTs
2fae4bc
@rekovic
Rename caloStage2Params 2017_v1_1_inconsistent to 2017_v1_1 after all…
b179474 
… Layer2 calibrations have been uploaded.
@rekovic
Add customisation L1TSettingsToCaloStage2Params_2017_v1_1.
ee4bda7
@bundocka @rekovic
Fixes to customiseSettings and tau LUT filename
f89d5cf
@thomreis @rekovic
Make input and output width of extrapolation LUT variable. Add getter…
80252f0 
… for input width configuration of LUT
@thomreis @rekovic
Use muon extrapolation LUTs with different input and output width
10bb48b
@thomreis @rekovic
Eta extrapolation LUT changes
723b0c4
@thomreis @rekovic
New extrapolation LUTs with 5 bit eta + 7 bit pt input and 4 bit outp…
dddc4e7 
…ut. For 0 (2) bit shift of output for eta (phi).
@thomreis @rekovic
Setting more likely FW version for change to new LUT format. Make eta…
e0d605d 
… shift configurable.
@thomreis @rekovic
Use new phi extrapolation LUT with improved tune.
6175621
@bundocka @rekovic
corrected caloSetup to include latest unpacker
89741a3
@gomber @rekovic
Added new CaloParams using ECAL layer1 calibrations, using tower et b…
74cb840 
…inning
@thomreis @rekovic
Add support for reading out of uGMT muon sets 2-6 to muon unpacker.
fed015c
@rekovic
New Layer1 calibs (binned in tower eta) now in renamed caloStage2Para…
0b811b2 
…ms_2017_v1_2_inconsistent_cfi. Customisation also provided.
@cmsbuild
Copy link
Contributor

Pull request #18133 was updated. @cmsbuild, @rekovic, @mulhearn, @davidlange6 can you please check and sign again.

@rekovic
Copy link
Contributor Author

rekovic commented Apr 19, 2017

hi @davidlange6. Thanks.
Comments addressed at the place you suggested and also here

@rekovic
Copy link
Contributor Author

rekovic commented Apr 19, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2017 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19239/console Started: 2017/04/19 11:53

@cmsbuild
Copy link
Contributor

+1
Tested at: 2b8ff58
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18133/19239/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18133/19239/summary.html

Comparison Summary:

  • You potentially added 10 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 1662 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1826273
  • DQMHistoTests: Total failures: 9289
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1816811
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@rekovic
Copy link
Contributor Author

rekovic commented Apr 19, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6 davidlange6 merged commit 2a5ba1f into cms-sw:master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomreis thomreis thomreis left review comments

@davidlange6 davidlange6 davidlange6 left review comments

Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-pending tests-approved
Projects
None yet
Milestone
CMSSW_9_1_X
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@rekovic @cmsbuild @smuzaffar @davidlange6 @thomreis @apana @bundocka @davignon @jbsauvan @gomber