add ecal digi SR flags to FEVT and RECO

[slava77]

ecal digi SR flags are needed for PF and can be useful for other studies.

This fixes a problem in RECOfromRECO workflows (or other places rerunning PF from reco) after merging #17794.

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

RecoHI/HiEgammaAlgos
RecoLocalCalo/Configuration

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@jazzitup, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

[slava77]

@emanueledimarco please cherry-pick this commit to your 90X PR #18016

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18829/console Started: 2017/03/31 12:47

[cmsbuild]

-1

Tested at: e1b346c

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18141/18829/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #18141 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[slava77]

@cmsbuild please test with #1102

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18831/console Started: 2017/03/31 13:55

[slava77]

@cmsbuild please test workflow 1102

wrong syntax last time

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18834/console Started: 2017/03/31 14:14

[slava77]

@smuzaffar
what did I do wrong in #18141 (comment) ?
the bot did not react to my @cmsbuild please test workflow 1102

[cmsbuild]

+1
Tested at: 713d5c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18141/18834/summary.html

[cmsbuild]

Comparison job queued.

[smuzaffar]

@slava77 ,your comment #18141 (comment) override your previous comment.

[smuzaffar]

@slava77 , my bad, your two comments were an hour apart, so bot should have reacted. I am looking...

[slava77]

On 3/31/17 3:38 PM, Malik Shahzad Muzaffar wrote: @slava77 <https://github.com/slava77> , my bad, your two comments were an hour apart, so bot should have reacted. I am looking...

yes, I waited for the first one to start and it the bot didn't react, so I went back to the regular "please test"

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbkIKp5z-z-tauCv_wEUNNcz_bByXks5rrQHfgaJpZM4MvglD>.

[smuzaffar]

actually bot is not trained to understand its own message I had the issue..... to noticed that previous tests are done. So in this case, bot assumed that previous tests are still running so it ignore your comment. I am going to fix this so that bot can understand I had the issue..... type of messages

[smuzaffar]

cms-bot is fixed now to recognize its own I had the issue.... message.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18141/18834/summary.html

[slava77]

+1

for #18141 713d5c2

• jenkins tests pass
• the failing 1102 workflow was tested to be working OK before the PR submission

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

[davidlange6]

+1