Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for conddbv2 PayloadInspector #18155

Merged
merged 4 commits into from Apr 4, 2017

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Mar 31, 2017

In this PR:

  • fix for binning initialisation of Histo2d (thanks Giovanni )
  • simplified interface, removing output data

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ggovi
Copy link
Contributor Author

ggovi commented Mar 31, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18843/console Started: 2017/03/31 22:54

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

Pull request #18155 was updated. @ggovi, @cmsbuild, @davidlange6 can you please check and sign again.

@ggovi
Copy link
Contributor Author

ggovi commented Apr 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18902/console Started: 2017/04/04 10:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

@ggovi
Copy link
Contributor Author

ggovi commented Apr 4, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 03c43df into cms-sw:master Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants