Hcal Plan1 validation plots #18159

kencall · 2017-04-01T06:23:06Z

Validation plots are added for HcalRecHits, HcalDigis, and HcalSimhits to support Hcal Plan1 configuration. Behavior is controlled through eras customization.

cmsbuild · 2017-04-01T06:23:26Z

A new Pull Request was created by @kencall for master.

It involves the following packages:

DQMOffline/Hcal
Validation/HcalDigis
Validation/HcalHits
Validation/HcalRecHits

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

kpedro88 · 2017-04-02T12:33:04Z

@cmsbuild please test

cmsbuild · 2017-04-02T12:33:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18856/console Started: 2017/04/02 18:21

cmsbuild · 2017-04-02T17:58:46Z

-1

Tested at: 737e348

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18159/18856/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D4_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D4+RecoFullGlobal_2023D4+HARVESTFullGlobal_2023D4.log

23234.0 step3

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D8_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D8+RecoFullGlobal_2023D8+HARVESTFullGlobal_2023D8.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Sun Apr 2 19:32:03 2017-date Sun Apr 2 19:29:45 2017 s - exit: 16640
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns --magField 38T_PostLS1 : FAILED - time: date Sun Apr 2 19:33:05 2017-date Sun Apr 2 19:30:02 2017 s - exit: 16640
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 --magField 38T_PostLS1 : FAILED - time: date Sun Apr 2 19:34:15 2017-date Sun Apr 2 19:30:37 2017 s - exit: 16640

cmsbuild · 2017-04-02T17:58:48Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

hatakeyamak · 2017-04-03T19:39:17Z

We needed to turn off the simhit vs rechit comparisons for fastsim. Still looking into what's going wrong with 2023 scenarios.

kpedro88 · 2017-04-04T07:48:27Z

@hatakeyamak rather than turning off the comparison, perhaps you should use a customization like this:

from Configuration.Eras.Modifier_fastSim_cff import fastSim
fastSim.toModify( hcalRecoAnalyzer, ModuleLabel = cms.untracked.string('famosSimHits') )

You would, of course, also need to add a ModuleLabel parameter in the analyzer.
(See e.g. https://github.com/cms-sw/cmssw/blob/master/Validation/HcalHits/python/HcalSimHitStudy_cfi.py#L12-L13.)

cmsbuild · 2017-04-04T11:55:54Z

Pull request #18159 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

hatakeyamak · 2017-04-04T12:11:26Z

@kpedro88 Right. It should be done now, as you suggested.

kencall · 2017-04-05T19:53:45Z

@kpedro88, can you restart the test?

kpedro88 · 2017-04-05T22:20:37Z

@cmsbuild please test

cmsbuild · 2017-04-05T22:20:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18958/console Started: 2017/04/06 00:26

…efinition from the Calotower DQMOffline code (used for Validation). Also, added a few iphi plots which are very useful for HEP17 validation.

cmsbuild · 2017-04-25T06:05:29Z

Pull request #18159 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

cmsbuild · 2017-04-25T06:25:11Z

Pull request #18159 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

hatakeyamak · 2017-04-25T10:43:28Z

@davidlange6 thank you for having a close look. We simplified the simhit depth plot implementation so that we can make the same plots without the pointer you pointed out. We also use this opportunity to remove the hard-coded bin definition from the Calotower DQMOffline code (used for Validation) and now it is in sync with how we do for rechit plots. Also, added a few iphi plots which are very useful for HEP17 validation.

@slava77 I think we cleaned up the commit so this should be ready to be considered for being merged.

Thank you.

kpedro88 · 2017-04-25T13:15:24Z

@cmsbuild please test

cmsbuild · 2017-04-25T13:15:41Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19377/console Started: 2017/04/25 15:17

dmitrijus · 2017-04-25T13:30:59Z

+1

cmsbuild · 2017-04-25T13:31:17Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

cmsbuild · 2017-04-25T15:09:59Z

+1
Tested at: f96ebf8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18159/19377/summary.html

cmsbuild · 2017-04-25T15:10:02Z

Comparison job queued.

davidlange6 · 2017-04-25T15:14:56Z

+1

cmsbuild · 2017-04-25T17:18:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18159/19377/summary.html

Comparison Summary:

You potentially added 34 lines to the logs
Reco comparison results: 69 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1779964
DQMHistoTests: Total failures: 15063
DQMHistoTests: Total nulls: 232
DQMHistoTests: Total successes: 1764496
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 1, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Apr 1, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 2, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Apr 2, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Apr 4, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 5, 2017

cmsbuild removed core-pending geometry-pending hlt-pending reconstruction-rejected labels Apr 25, 2017

Simplified the simhit depth plots. Also, removed the hard-coded bin d…

fe8c657

…efinition from the Calotower DQMOffline code (used for Validation). Also, added a few iphi plots which are very useful for HEP17 validation.

clean up unnecessary MonitorElement

f96ebf8

cmsbuild added tests-started and removed tests-pending labels Apr 25, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Apr 25, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 25, 2017

cmsbuild added orp-approved and removed orp-pending labels Apr 25, 2017

cmsbuild merged commit c555c87 into cms-sw:master Apr 25, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 25, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hcal Plan1 validation plots #18159

Hcal Plan1 validation plots #18159

kencall commented Apr 1, 2017

cmsbuild commented Apr 1, 2017

kpedro88 commented Apr 2, 2017

cmsbuild commented Apr 2, 2017 •

edited

cmsbuild commented Apr 2, 2017

cmsbuild commented Apr 2, 2017

hatakeyamak commented Apr 3, 2017

kpedro88 commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

hatakeyamak commented Apr 4, 2017 •

edited

kencall commented Apr 5, 2017

kpedro88 commented Apr 5, 2017

cmsbuild commented Apr 5, 2017 •

edited

cmsbuild commented Apr 25, 2017

cmsbuild commented Apr 25, 2017

hatakeyamak commented Apr 25, 2017 •

edited

kpedro88 commented Apr 25, 2017

cmsbuild commented Apr 25, 2017 •

edited

dmitrijus commented Apr 25, 2017

cmsbuild commented Apr 25, 2017

cmsbuild commented Apr 25, 2017

cmsbuild commented Apr 25, 2017

davidlange6 commented Apr 25, 2017

cmsbuild commented Apr 25, 2017

Hcal Plan1 validation plots #18159

Hcal Plan1 validation plots #18159

Conversation

kencall commented Apr 1, 2017

cmsbuild commented Apr 1, 2017

kpedro88 commented Apr 2, 2017

cmsbuild commented Apr 2, 2017 • edited

cmsbuild commented Apr 2, 2017

cmsbuild commented Apr 2, 2017

hatakeyamak commented Apr 3, 2017

kpedro88 commented Apr 4, 2017

cmsbuild commented Apr 4, 2017

hatakeyamak commented Apr 4, 2017 • edited

kencall commented Apr 5, 2017

kpedro88 commented Apr 5, 2017

cmsbuild commented Apr 5, 2017 • edited

cmsbuild commented Apr 25, 2017

cmsbuild commented Apr 25, 2017

hatakeyamak commented Apr 25, 2017 • edited

kpedro88 commented Apr 25, 2017

cmsbuild commented Apr 25, 2017 • edited

dmitrijus commented Apr 25, 2017

cmsbuild commented Apr 25, 2017

cmsbuild commented Apr 25, 2017

cmsbuild commented Apr 25, 2017

davidlange6 commented Apr 25, 2017

cmsbuild commented Apr 25, 2017

cmsbuild commented Apr 2, 2017 •

edited

hatakeyamak commented Apr 4, 2017 •

edited

cmsbuild commented Apr 5, 2017 •

edited

hatakeyamak commented Apr 25, 2017 •

edited

cmsbuild commented Apr 25, 2017 •

edited