Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hep17 and hf compression luts #18173

Merged
merged 1 commit into from Apr 11, 2017

Conversation

akhukhun
Copy link
Contributor

@akhukhun akhukhun commented Apr 3, 2017

This is to revert the HEP17 LUTs and make them same as for the other HE channels for the first 10 bits, as discussed in the Hcal DPG trigger meeting with @nsmith- .
Also extending HF compression LUTs to 11 bits (this is now only important for online HCAL compression LUTs).

Would be good to have it signed off by L1.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

A new Pull Request was created by @akhukhun for master.

It involves the following packages:

CalibCalorimetry/CaloTPG

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 3, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18875/console Started: 2017/04/03 16:21

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

@franzoni
Copy link

franzoni commented Apr 7, 2017

The changes in CalibCalorimetry/CaloTPG
. read ok to us
. in the substance of the array anche and computations, are far from what AlCa/Db can judge
. suggestion: change the cast to a more modern version

We let the L1T signature vet the full depth of the content.

@franzoni
Copy link

franzoni commented Apr 7, 2017

+1

@rekovic
Copy link
Contributor

rekovic commented Apr 11, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 78452f7 into cms-sw:master Apr 11, 2017
@akhukhun akhukhun deleted the fix-hep17andhf-compression branch February 22, 2018 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants