New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix hep17 and hf compression luts #18173
Conversation
A new Pull Request was created by @akhukhun for master. It involves the following packages: CalibCalorimetry/CaloTPG @ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
The changes in CalibCalorimetry/CaloTPG We let the L1T signature vet the full depth of the content. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
+1 |
This is to revert the HEP17 LUTs and make them same as for the other HE channels for the first 10 bits, as discussed in the Hcal DPG trigger meeting with @nsmith- .
Also extending HF compression LUTs to 11 bits (this is now only important for online HCAL compression LUTs).
Would be good to have it signed off by L1.