Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hep17 and hf compression luts #18176

Merged

Conversation

akhukhun
Copy link
Contributor

@akhukhun akhukhun commented Apr 3, 2017

Backport of #18173 .

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

A new Pull Request was created by @akhukhun for CMSSW_9_0_X.

It involves the following packages:

CalibCalorimetry/CaloTPG

@ghellwig, @arunhep, @cerminar, @cmsbuild, @rekovic, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor

kpedro88 commented Apr 3, 2017

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18876/console Started: 2017/04/03 16:24

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2017

@abdoulline
Copy link

@akhukhun
I suppose it's indispensable for 901 MC production(s)?

@akhukhun
Copy link
Contributor Author

akhukhun commented Apr 4, 2017

@abdoulline it should not have dramatic effect but I guess it's better to have it fixed this way.

@abdoulline
Copy link

abdoulline commented Apr 4, 2017 via email

@franzoni
Copy link

franzoni commented Apr 7, 2017

same comments as:
#18173 (comment)

@franzoni
Copy link

franzoni commented Apr 7, 2017

+1

@rekovic
Copy link
Contributor

rekovic commented Apr 11, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 327fde8 into cms-sw:CMSSW_9_0_X Apr 12, 2017
@akhukhun akhukhun deleted the fix-hep17andhf-compression-90X branch February 22, 2018 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants