New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[91X] SiPixelAli PCL payload creation thresholds from db - Consumer Code #18196
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: Alignment/CommonAlignmentProducer @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
The last commit is just to ensure direct backward compatibility with the current version of the DQMGUI rendering plugin, since it is unclear if I can match the deployment schedule in this cycle. |
please test |
The tests are being triggered in jenkins. |
@Dr15Jones thanks! |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
+1 |
Greeting,
this is a follow-up Pull Request to #18087. The Pixel Alignment Prompt Calibration Loop consumer code in
/Alignment/MillePedeAlignmentAlgorithm
is changed to use thresholds for payload creation from DataBase instead that from python configuration file.The two main areas affected are:
Alignment/MillePedeAlignmentAlgorithm/interface(src)/MillePedeFileReader.h(cc)
class that presides to the checking of the payload features.Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeDQMModule.h(cc)
class that provides the DQM monitoring at theAlCaHarvesting
stage.To let PR tests run (since the new
AlignPCLThresholds
payload is not yet integrated) I am providing the needed conditions viaESSource
inAlCaSkimming
(ALCARECOPromptCalibProdSiPixelAli_cff.py
)AlCaHarvesting
(AlcaSiPixelAliHarvester_cff.py
)I will remove the external sources when the payload will be integrated in Global Tag (requests in the Conditon Data Browser are here and here ).
Once merged a follow-up Pull Request to https://github.com/dmwm/deployment will be issued to fix the DQMGUI rendering plugin.
I attach here an example of how it will look like once finally integrated (using the payload at
/afs/cern.ch/user/m/musich/public/AlCa/AlignPCLThresholds_Payload/mythresholds.db
, that features thresholds dependent on the alignable partition).attn: @mschrode @meng-xiao