Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[91X] SiPixelAli PCL payload creation thresholds from db - Consumer Code #18196

Merged
merged 18 commits into from Apr 6, 2017

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 4, 2017

Greeting,
this is a follow-up Pull Request to #18087. The Pixel Alignment Prompt Calibration Loop consumer code in /Alignment/MillePedeAlignmentAlgorithm is changed to use thresholds for payload creation from DataBase instead that from python configuration file.
The two main areas affected are:

  • Alignment/MillePedeAlignmentAlgorithm/interface(src)/MillePedeFileReader.h(cc) class that presides to the checking of the payload features.
  • Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeDQMModule.h(cc) class that provides the DQM monitoring at the AlCaHarvesting stage.

To let PR tests run (since the new AlignPCLThresholds payload is not yet integrated) I am providing the needed conditions via ESSource in

  • AlCaSkimming (ALCARECOPromptCalibProdSiPixelAli_cff.py)
  • AlCaHarvesting (AlcaSiPixelAliHarvester_cff.py)

I will remove the external sources when the payload will be integrated in Global Tag (requests in the Conditon Data Browser are here and here ).
Once merged a follow-up Pull Request to https://github.com/dmwm/deployment will be issued to fix the DQMGUI rendering plugin.

I attach here an example of how it will look like once finally integrated (using the payload at /afs/cern.ch/user/m/musich/public/AlCa/AlignPCLThresholds_Payload/mythresholds.db, that features thresholds dependent on the alignable partition).

screenshot 2017-04-04 17 43 54

attn: @mschrode @meng-xiao

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/CommonAlignmentProducer
Alignment/MillePedeAlignmentAlgorithm

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@mschrode, @pakhotin, @ghellwig, @tocheng, @tlampen this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ghellwig
Copy link

ghellwig commented Apr 4, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18918/console Started: 2017/04/04 19:28

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

Pull request #18196 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Apr 6, 2017

The last commit is just to ensure direct backward compatibility with the current version of the DQMGUI rendering plugin, since it is unclear if I can match the deployment schedule in this cycle.

@ghellwig
Copy link

ghellwig commented Apr 6, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18973/console Started: 2017/04/06 11:59

@ghellwig
Copy link

ghellwig commented Apr 6, 2017

@Dr15Jones thanks!

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18196/18973/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • results differ 376 all_mini_OldVSNew_TTbarPUwf50202p0 JR results differ 1232 all_OldVSNew_TTbarPUwf50202p0 SUMMARY Reco comparison results: 1608 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1913169
  • DQMHistoTests: Total failures: 35706
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1877290
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@ghellwig
Copy link

ghellwig commented Apr 6, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants