Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for BON/BOFF PopConAnalyzer #18217

Merged
merged 1 commit into from Apr 6, 2017

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Apr 5, 2017

This fix removes the copy of the Payload from reference Tag to target Tag, which was triggered in the case of the update.
This copy is not required since the concerned payload is already in the DB. Instead, the update of the target Tag with the addition of the new iov referencing the Payload is implemented.
This is mandatory in case of change of boost serialization, in order not to create a new payload with the same content of the reference one but a different hash.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondTools/RunInfo

@ggovi, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@ggovi ggovi changed the title Fix forBON/BOFF PopConAnalyzer Fix for BON/BOFF PopConAnalyzer Apr 5, 2017
@ggovi
Copy link
Contributor Author

ggovi commented Apr 5, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/18950/console Started: 2017/04/05 20:31

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

Comparison job queued.

@ggovi
Copy link
Contributor Author

ggovi commented Apr 5, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2017

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2017

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d0c0c73 into cms-sw:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants