fix histogram HLT_Higgs_PhotonJet_trigvsnvtx #18258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages: DQMOffline/Trigger @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
mtosi
reviewed
Apr 7, 2017
| @@ -322,7 +322,8 @@ HigPhotonJetHLTOfflineSource::endRun(const edm::Run & iRun, | |||
| { | |||
| // Normalize to the total number of events in the run | |||
| TH2F* h = trigvsnvtx_->getTH2F(); | |||
| double norm = evtsrun_*hltPathsToCheck_.size()/h->Integral(); | |||
| double integral = h->Integral(); | |||
| double norm = (integral > 0.) ? evtsrun_*hltPathsToCheck_.size()/integral : 1.; | |||
There was a problem hiding this comment.
sorry, I'm confused
shouldn't such a computation be done in the HARVESTING step ?
There was a problem hiding this comment.
Maybe; I'm just trying to fix the comparison plot.
|
on my last comment, I let DQM core people to comment ;)
but, let me add a request
because you are already editing this file,
could you please add the GenericTriggerEventFlag
in order to select events w/ HVON, please ?
thanks
…On Fri, Apr 7, 2017 at 1:58 PM, Kevin Pedro ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In DQMOffline/Trigger/src/HigPhotonJetHLTOfflineSource.cc
<#18258 (comment)>:
> @@ -322,7 +322,8 @@ HigPhotonJetHLTOfflineSource::endRun(const edm::Run & iRun,
{
// Normalize to the total number of events in the run
TH2F* h = trigvsnvtx_->getTH2F();
- double norm = evtsrun_*hltPathsToCheck_.size()/h->Integral();
+ double integral = h->Integral();
+ double norm = (integral > 0.) ? evtsrun_*hltPathsToCheck_.size()/integral : 1.;
Maybe; I'm just trying to fix the comparison plot.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18258 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt583jQT9BIc4iMQPf1Qn3KZqM9-Aihks5rtiT6gaJpZM4M2zX1>
.
|
|
@mtosi don't know what that is or where to add it, sorry |
|
please, as an example
give a look at
https://github.com/kpedro88/cmssw/blob/e808d7d1fffafd6c98ffdf70cd4d0a0c07acff3b/DQMOffline/Trigger/plugins/METMonitor.cc
where I define 2 instances of this class
one for the denominator and the other for the numerator
the important point for the HV is in the den one
hope it helps
thanks !
mia
…On Fri, Apr 7, 2017 at 2:24 PM, Kevin Pedro ***@***.***> wrote:
@mtosi <https://github.com/mtosi> don't know what that is or where to add
it, sorry
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18258 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58wpR2_jRhNU8Mxojih38LnwXWsHYks5rtisWgaJpZM4M2zX1>
.
|
|
I think Kevin is just fixing a bug that annoys him. If there are more bugs perhaps the code responsibles can get involved.
On Apr 7, 2017, at 2:37 PM, mia tosi <notifications@github.com<mailto:notifications@github.com>> wrote:
please, as an example
give a look at
https://github.com/kpedro88/cmssw/blob/e808d7d1fffafd6c98ffdf70cd4d0a0c07acff3b/DQMOffline/Trigger/plugins/METMonitor.cc
where I define 2 instances of this class
one for the denominator and the other for the numerator
the important point for the HV is in the den one
hope it helps
thanks !
mia
On Fri, Apr 7, 2017 at 2:24 PM, Kevin Pedro ***@***.******@***.***>> wrote:
@mtosi <https://github.com/mtosi> don't know what that is or where to add
it, sorry
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18258 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58wpR2_jRhNU8Mxojih38LnwXWsHYks5rtisWgaJpZM4M2zX1>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#18258 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzyw_4MIcy4ZevtFIbUyNtDd-1fdHjcks5rti2ngaJpZM4M2zX1>.
|
|
thanks for the information
and sorry but I mis-understood .....
I'll contact HIG-HLT DQM developers, then
mia
On Fri, Apr 7, 2017 at 2:49 PM, David Lange <notifications@github.com>
wrote:
… I think Kevin is just fixing a bug that annoys him. If there are more bugs
perhaps the code responsibles can get involved.
On Apr 7, 2017, at 2:37 PM, mia tosi ***@***.***<mailto:
***@***.***>> wrote:
please, as an example
give a look at
https://github.com/kpedro88/cmssw/blob/e808d7d1fffafd6c98ffdf70cd4d0a
0c07acff3b/DQMOffline/Trigger/plugins/METMonitor.cc
where I define 2 instances of this class
one for the denominator and the other for the numerator
the important point for the HV is in the den one
hope it helps
thanks !
mia
On Fri, Apr 7, 2017 at 2:24 PM, Kevin Pedro ***@***.***<
***@***.***>>
wrote:
> @mtosi <https://github.com/mtosi> don't know what that is or where to
add
> it, sorry
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#18258 (comment)>, or
mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AEt58wpR2_
jRhNU8Mxojih38LnwXWsHYks5rtisWgaJpZM4M2zX1>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/cms-
sw/cmssw/pull/18258#issuecomment-292524810>, or mute the thread<
https://github.com/notifications/unsubscribe-auth/AEzyw_
4MIcy4ZevtFIbUyNtDd-1fdHjcks5rti2ngaJpZM4M2zX1>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18258 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEt58wz2eyZZGKN_ROWRvQQ4xfJnRJbeks5rtjDYgaJpZM4M2zX1>
.
|
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a divide by zero problem in this histogram, which caused the PR comparisons to report it as a failure.