Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin simplification of Principal #1828

Merged
merged 2 commits into from Dec 16, 2013
Merged

Begin simplification of Principal #1828

merged 2 commits into from Dec 16, 2013

Conversation

Dr15Jones
Copy link
Contributor

Principal never calls unscheduledFill, it is only called from the UnscheduledProductHolder

@Dr15Jones
Principal no longer calls unscheduledFill
df3c5cd 
Previous changes had ProductHolders handle the unscheduled running of modules. However, Principal::getProvenance() was a hold over to the old way. This brings it inline with the rest of the code.
@Dr15Jones
Renaming to better match actual functionality
2b172d0 
Principal::getProductByIndex and Principal::ConstProductPtr where renamed to Prinicpal::getProductHolderByIndex and Principal::ConstProductHolderPtr since the functionality was dealing with ProductHolders and not Products.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X.

Begin simplification of Principal

It involves the following packages:

FWCore/Framework

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1828/1774/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Dec 16, 2013
@ktf
Merge pull request #1828 from Dr15Jones/PrincipalNeverCallsUnschedule…
e8e378b 
…dFill

Framework update -- Begin simplification of Principal
@ktf ktf merged commit e8e378b into cms-sw:CMSSW_7_0_X Dec 16, 2013
@Dr15Jones Dr15Jones deleted the PrincipalNeverCallsUnscheduledFill branch December 19, 2013 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @ktf