New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexible SOI config for HF #18284
Flexible SOI config for HF #18284
Conversation
A new Pull Request was created by @igv4321 (Igor Volobouev) for master. It involves the following packages: RecoLocalCalo/HcalRecProducers @perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Pull request #18284 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
Sorry, forgot something. This PR should be complete now. |
Sorry, not yet... |
Pull request #18284 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again. |
OK, pushed the right file. This PR is really complete now. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
+1 |
Introducing flexible sample of interest configuration for HF (to have the capability to reconstruct pre- and post-samples). The mode of operation is described in the cfi comments.
This PR will not modify any existing relval results.