Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible SOI config for HF #18284

Merged
merged 3 commits into from Apr 13, 2017
Merged

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Apr 10, 2017

Introducing flexible sample of interest configuration for HF (to have the capability to reconstruct pre- and post-samples). The mode of operation is described in the cfi comments.

This PR will not modify any existing relval results.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @igv4321 (Igor Volobouev) for master.

It involves the following packages:

RecoLocalCalo/HcalRecProducers

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mariadalfonso this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19048/console Started: 2017/04/10 12:55

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #18284 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

@igv4321
Copy link
Contributor Author

igv4321 commented Apr 10, 2017

Sorry, forgot something. This PR should be complete now.

@igv4321
Copy link
Contributor Author

igv4321 commented Apr 10, 2017

Sorry, not yet...

@cmsbuild
Copy link
Contributor

Pull request #18284 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

@igv4321
Copy link
Contributor Author

igv4321 commented Apr 10, 2017

OK, pushed the right file. This PR is really complete now.

@kpedro88
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 10, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19055/console Started: 2017/04/10 16:58

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18284/19055/summary.html

Comparison Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1917209
  • DQMHistoTests: Total failures: 29473
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1887563
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@bsunanda
Copy link
Contributor

@perrotta @slava77 Please sign this - it is needed for phisymmetry calibration

@perrotta
Copy link
Contributor

+1
New parameters allow for more possibilities of selecting the "Sample Of Interest"
Default values preserve the previous behavior, and therefore no effects on the results is visible

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4ca9c7d into cms-sw:master Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants