Add isolated charged hadron flag to RECO+AOD #18324

ahinzmann · 2017-04-12T08:51:02Z

Followup of #18308

This PR adds a valueMap "chargedHadronPFTrackIsolation" for the PFCandisdates to RECO+AOD.
Charged hadrons with track pT > 1 GeV and rawCaloEnergy > 0.5 GeV are tagged on RECO.
With isolated charged hadrons, calorimeter response can be measured in data and simulation with fine granularity, enabling PF hadron calibration at AOD level.

runTheMatrix -l limited works.

It was checked that the variables in RECO+AOD are filled correctly with reasonable values.

Size with/without this change based on workflow 10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017 is summarized below:

New collection in RECO+AOD:
booledmValueMap_chargedHadronPFTrackIsolation__RECO. 677.8 278.7

cmsbuild · 2017-04-12T08:51:21Z

A new Pull Request was created by @ahinzmann for master.

It involves the following packages:

RecoParticleFlow/Configuration
RecoParticleFlow/PFProducer

@perrotta, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@mmarionncern, @lgray, @rafaellopesdesa, @bachtis, @cbernet this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

perrotta · 2017-04-12T09:30:09Z

@ahinzmann : is this supposed to replace #18308 ?
(Please clarify, and close any of them which is not needed any more)

ahinzmann · 2017-04-12T09:36:04Z

#18308 is factorized in two PR. This is supposed to replace the AOD+RECO part of #18308. MiniAOD will follow after discussion at xpog

perrotta · 2017-04-12T09:40:37Z

please test

cmsbuild · 2017-04-12T09:40:54Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19130/console Started: 2017/04/12 11:47

slava77 · 2017-04-12T11:11:48Z

On 4/12/17 1:51 AM, ahinzmann wrote: Followup of #18308 <#18308>

what's the reason to move to a new PR? This disrupts review process.

cmsbuild · 2017-04-12T11:12:51Z

+1
Tested at: 27c1abc
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18324/19130/summary.html

cmsbuild · 2017-04-12T11:12:54Z

Comparison job queued.

cmsbuild · 2017-04-12T13:35:51Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18324/19130/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 21 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1921525
DQMHistoTests: Total failures: 14573
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 1906778
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

cmsbuild · 2017-04-12T13:52:15Z

Pull request #18324 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

ahinzmann · 2017-04-12T13:55:31Z

Renamed according to comment by @slava77 in #18308

slava77 · 2017-04-12T14:05:48Z

@cmsbuild please test

slava77 · 2017-04-18T20:45:09Z

RecoParticleFlow/PFProducer/plugins/ChargedHadronPFTrackIsolationProducer.cc

+  // get a view of our Candidates via the base candidates
+  typedef edm::View<reco::PFCandidate> PFCandidateView;
+  edm::Handle<PFCandidateView> Candidates;
+  evt.getByToken(Candidates_token, Candidates);


start local variables and data members with lower case letter. Capitalization is reserved for class names.

slava77 · 2017-04-18T20:46:23Z

RecoParticleFlow/PFProducer/plugins/ChargedHadronPFTrackIsolationProducer.cc

+
+  std::vector<bool> values;
+
+  for( PFCandidateView::const_iterator c = Candidates->begin(); c!=Candidates->end(); ++c) {


for range loop seems more appropriate for (auto cons& c : *candidates) {

slava77 · 2017-04-18T21:00:04Z

RecoParticleFlow/PFProducer/plugins/ChargedHadronPFTrackIsolationProducer.cc

+      if( theElements.empty() ) continue;
+      const reco::PFBlockRef blockRef = theElements[0].first;
+      const edm::OwnVector<reco::PFBlockElement>& elements = blockRef->elements();
+      for(unsigned int iEle=0; iEle<elements.size(); iEle++) {	         	 // Find the tracks in the block


similarly

for (auto const& ele : elements){ ...

cmsbuild · 2017-04-19T08:19:02Z

Pull request #18324 was updated. @perrotta, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

perrotta · 2017-04-19T08:39:59Z

please test

cmsbuild · 2017-04-19T08:40:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19234/console Started: 2017/04/19 10:41

cmsbuild · 2017-04-19T09:26:17Z

+1
Tested at: 62fd67c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18324/19234/summary.html

cmsbuild · 2017-04-19T09:26:20Z

Comparison job queued.

cmsbuild · 2017-04-19T10:49:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18324/19234/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1642 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1826307
DQMHistoTests: Total failures: 35953
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 1790180
DQMHistoTests: Total skipped: 173
DQMHistoTests: Total Missing objects: 0
Checked 94 log files, 14 edm output root files, 23 DQM output files

slava77 · 2017-04-19T17:08:32Z

+1

for #18324 62fd67c

new producer to make booledmValueMap_chargedHadronPFTrackIsolation is introduced as described; the branch appears up to AOD.
jenkins tests pass and AOD ouput in 1000.0 shows the new branch is in place
local test with 136.76 shows that the module is running at somewhat negligible CPU cost (0.5 ms/evt) and creates an output of about 100 bytes/event in size (one bool per about 2K PF candidates in this sample with about 50:1 false:true ratio).

cmsbuild · 2017-04-19T17:08:52Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

davidlange6 · 2017-04-20T06:59:08Z

+1

charged hadron isolation in RECO

27c1abc

cmsbuild added this to the Next CMSSW_9_1_X milestone Apr 12, 2017

cmsbuild added comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Apr 12, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 12, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 12, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 12, 2017

rename

c86a68d

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Apr 12, 2017

slava77 reviewed Apr 18, 2017

View reviewed changes

make edm global

62fd67c

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Apr 19, 2017

cmsbuild added tests-started and removed tests-pending labels Apr 19, 2017

cmsbuild added tests-approved and removed tests-started labels Apr 19, 2017

cmsbuild added comparison-available and removed comparison-pending labels Apr 19, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Apr 19, 2017

cmsbuild added orp-approved and removed orp-pending labels Apr 20, 2017

cmsbuild merged commit d411fdf into cms-sw:master Apr 20, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add isolated charged hadron flag to RECO+AOD #18324

Add isolated charged hadron flag to RECO+AOD #18324

ahinzmann commented Apr 12, 2017 •

edited

cmsbuild commented Apr 12, 2017

perrotta commented Apr 12, 2017

ahinzmann commented Apr 12, 2017

perrotta commented Apr 12, 2017

cmsbuild commented Apr 12, 2017 •

edited

slava77 commented Apr 12, 2017 via email

cmsbuild commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

ahinzmann commented Apr 12, 2017

slava77 commented Apr 12, 2017

slava77 Apr 18, 2017

slava77 Apr 18, 2017

slava77 Apr 18, 2017

cmsbuild commented Apr 19, 2017

perrotta commented Apr 19, 2017

cmsbuild commented Apr 19, 2017 •

edited

cmsbuild commented Apr 19, 2017

cmsbuild commented Apr 19, 2017

cmsbuild commented Apr 19, 2017

slava77 commented Apr 19, 2017

cmsbuild commented Apr 19, 2017

davidlange6 commented Apr 20, 2017


		std::vector<bool> values;

		for( PFCandidateView::const_iterator c = Candidates->begin(); c!=Candidates->end(); ++c) {

Add isolated charged hadron flag to RECO+AOD #18324

Add isolated charged hadron flag to RECO+AOD #18324

Conversation

ahinzmann commented Apr 12, 2017 • edited

cmsbuild commented Apr 12, 2017

perrotta commented Apr 12, 2017

ahinzmann commented Apr 12, 2017

perrotta commented Apr 12, 2017

cmsbuild commented Apr 12, 2017 • edited

slava77 commented Apr 12, 2017 via email

cmsbuild commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

cmsbuild commented Apr 12, 2017

ahinzmann commented Apr 12, 2017

slava77 commented Apr 12, 2017

slava77 Apr 18, 2017

Choose a reason for hiding this comment

slava77 Apr 18, 2017

Choose a reason for hiding this comment

slava77 Apr 18, 2017

Choose a reason for hiding this comment

cmsbuild commented Apr 19, 2017

perrotta commented Apr 19, 2017

cmsbuild commented Apr 19, 2017 • edited

cmsbuild commented Apr 19, 2017

cmsbuild commented Apr 19, 2017

cmsbuild commented Apr 19, 2017

slava77 commented Apr 19, 2017

cmsbuild commented Apr 19, 2017

davidlange6 commented Apr 20, 2017

ahinzmann commented Apr 12, 2017 •

edited

cmsbuild commented Apr 12, 2017 •

edited

cmsbuild commented Apr 19, 2017 •

edited