Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore HCAL DQM to offline workflow #18353

Merged

Conversation

DryRun
Copy link
Contributor

@DryRun DryRun commented Apr 13, 2017

Fix for non-backwards-compatible FED-to-crate tables, as discussed in #17657: offline workflows have been modified to use crateId instead of FED number.

FEDs are still used for online workflows.

This PR contains most of the other commits from this year, which were not merged pending a fix for the fed2crate issue.

virtual uint32_t getBin(HcalElectronicsId const&);

virtual int nbins() {
std::cout << "[debug] CrateQuantity: returning nbins = " << _crates.size() << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably did this for debugging purposes and forgot to disable afterwards.
Either way, cout should not be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this. I committed a fix removing this line.

@cmsbuild
Copy link
Contributor

Pull request #18353 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again.

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 20, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19288/console Started: 2017/04/20 11:39

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18353/19288/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3308 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1826205
  • DQMHistoTests: Total failures: 45133
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1780899
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@davidlange6
Copy link
Contributor

+1
from various conversations I believe there is some consensus that splitting the "offline", "online" and "common" parts of this into separate analyzers would greatly simplify and clarify the code. Hopefully that can be done in the near future..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants