New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore HCAL DQM to offline workflow #18353
Restore HCAL DQM to offline workflow #18353
Conversation
…to GeometryRecoDB did it...
virtual uint32_t getBin(HcalElectronicsId const&); | ||
|
||
virtual int nbins() { | ||
std::cout << "[debug] CrateQuantity: returning nbins = " << _crates.size() << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably did this for debugging purposes and forgot to disable afterwards.
Either way, cout should not be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this. I committed a fix removing this line.
Pull request #18353 was updated. @cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please check and sign again. |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
Fix for non-backwards-compatible FED-to-crate tables, as discussed in #17657: offline workflows have been modified to use crateId instead of FED number.
FEDs are still used for online workflows.
This PR contains most of the other commits from this year, which were not merged pending a fix for the fed2crate issue.