Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-sim06 Add an example to produce geometry summary for a given configuration #18371

Merged
merged 4 commits into from Apr 26, 2017

Conversation

bsunanda
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

SimG4Core/PrintGeomInfo

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19197/console Started: 2017/04/17 12:26

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18371/19197/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3205 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1819476
  • DQMHistoTests: Total failures: 15234
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 1804068
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #18371 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

@bsunanda bsunanda changed the title Run2 sim06 Add an example to produce geometry summary for a given configuration Run2-sim06 Add an example to produce geometry summary for a given configuration Apr 18, 2017
@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 18, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19210/console Started: 2017/04/18 12:11

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18371/19210/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1744 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1819408
  • DQMHistoTests: Total failures: 20686
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1798549
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@civanch
Copy link
Contributor

civanch commented Apr 18, 2017

@bsunanda , sorry, I postpone this PR to time when will be in the office and want to run the test with different use-cases. I would guess it is not urgent to integrate it in pre3.

@cmsbuild
Copy link
Contributor

Pull request #18371 was updated. @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19266/console Started: 2017/04/19 18:08

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18371/19266/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1602 differences found in the comparisons
  • DQMHistoTests: Total files compared: 23
  • DQMHistoTests: Total histograms compared: 1826239
  • DQMHistoTests: Total failures: 34972
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1791094
  • DQMHistoTests: Total skipped: 173
  • DQMHistoTests: Total Missing objects: 0
  • Checked 94 log files, 14 edm output root files, 23 DQM output files

@civanch
Copy link
Contributor

civanch commented Apr 26, 2017

+1
@bsunanda, this PR is working fine, may be you should not change g4Overlap script, instead we should duplicate for several sub-detectors but we will do this in new PRs

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @Muzaffar, @davidlange6, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants