Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 workflow updates (add D14, D12 in short matrix, new OOT PU settings, Timing) #18373

Merged
merged 10 commits into from Apr 27, 2017

Conversation

kpedro88
Copy link
Contributor

This PR contains several Phase2 workflow updates toward the Muon/Barrel TDR:

  1. Add D14 scenario as D12 w/ T5 tracker (extra disk), corresponding workflows
  2. Remove D7 from short matrix (uses C1, nobody really cares anymore), add D12
  3. Default OOT window for Phase2 is now -3,+3 for 140 and 200 PU. Alternate versions with the old -12,+3 and a new special option -6,+6 are added (only for 25ns).
  4. Reduce code duplication in relval_2023 (used to port upgrade workflows to regular matrix); here I fixed a bug where the trackingOnly workflows in the upgrade matrix didn't have the right beamspot for 14 TeV
  5. Remove separate _Timing workflow keys (associated WF numbers added to skip list so other numbers won't change); instead add timing workflow variations as 2XXXX.2, only for ttbar (just Era changes), and run in IBs

attn: @boudoul @makortel @calabria @slava77 @mdhildreth

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @dgulhan this is something you requested to watch as well.
@Muzaffar, @davidlange6, @smuzaffar you are the release manager for this.

cms-bot commands are listed here #13028

@kpedro88
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19203/console Started: 2017/04/17 20:08

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18373/19203/summary.html

Comparison Summary:

  • You potentially added 73 lines to the logs
  • Reco comparison results: 3243 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1766732
  • DQMHistoTests: Total failures: 30047
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 1736518
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@kpedro88
Copy link
Contributor Author

+1

@kpedro88
Copy link
Contributor Author

also attn @lgray

@civanch
Copy link
Contributor

civanch commented Apr 19, 2017

+1

@kpedro88
Copy link
Contributor Author

@fabozzi @GurpreetSinghChahal please sign

@fabozzi
Copy link
Contributor

fabozzi commented Apr 21, 2017

+1

@cmsbuild
Copy link
Contributor

Pull request #18373 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @davidlange6 can you please check and sign again.

@kpedro88
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 26, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/19421/console Started: 2017/04/26 18:02

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18373/19421/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1690 differences found in the comparisons
  • DQMHistoTests: Total files compared: 22
  • DQMHistoTests: Total histograms compared: 1730813
  • DQMHistoTests: Total failures: 37810
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 1692837
  • DQMHistoTests: Total skipped: 166
  • DQMHistoTests: Total Missing objects: 0
  • Checked 90 log files, 14 edm output root files, 22 DQM output files

@kpedro88
Copy link
Contributor Author

+1

@Dr15Jones
Copy link
Contributor

It appears this change is causing two workflows to fail in the IB 26234.0 and 26234.2 with the error

----- Begin Fatal Exception 27-Apr-2017 19:37:49 CEST-----------------------
An exception of category 'StdException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 3
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module TTStubBuilder_Phase2TrackerDigi_/'TTStubsFromPhase2TrackerDigis'
Exception Message:
A std::exception was thrown.
vector::_M_range_check: __n (which is 12) >= this->size() (which is 12)
----- End Fatal Exception -------------------------------------------------

@kpedro88
Copy link
Contributor Author

Hm, those are the new workflows that were added for D14 (which is D12 with T5, the extra pixel disk).

@sviret @boudoul can you check why the track trigger does not work for D14, but works for D11?

@boudoul
Copy link
Contributor

boudoul commented May 1, 2017

Hi , it does not work (yet) for D11, it has been disabled in D11 WFs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants