Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link dependencies on DataFormats/WrappedStdDictionaries #1839

Merged
merged 1 commit into from Dec 16, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Dec 16, 2013

This pull request adds missing link dependencies of some Framework unit tests on DataFormats/WrappedStdDictionaries. The ROOT6 version of this pull request was already merged. This is for ROOT 5, to keep things consistent.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Add link dependencies on DataFormats/WrappedStdDictionaries

It involves the following packages:

FWCore/Framework

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@ktf
Copy link
Contributor

ktf commented Dec 16, 2013

Bypassing this.

ktf added a commit that referenced this pull request Dec 16, 2013
ROOT6 -- Add link dependencies on DataFormats/WrappedStdDictionaries
@ktf ktf merged commit 67f4f31 into cms-sw:CMSSW_7_0_X Dec 16, 2013
@ktf
Copy link
Contributor

ktf commented Dec 16, 2013

BTW, if something applies to ROOT6 and ROOT5, you are probably better off doing it only for ROOT5 and let Jenkins do the rebase on top of ROOT6 branch for you.

@wmtan wmtan deleted the AddMissingLinkDependency branch December 16, 2013 21:04
ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
Move Root 6.02 to the tip of the branch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants